From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762258AbcLPWTx (ORCPT ); Fri, 16 Dec 2016 17:19:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759315AbcLPWTp (ORCPT ); Fri, 16 Dec 2016 17:19:45 -0500 Date: Fri, 16 Dec 2016 16:19:42 -0600 From: Josh Poimboeuf To: Petr Mladek Cc: Jessica Yu , Jiri Kosina , Miroslav Benes , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org, Michael Ellerman , Heiko Carstens , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Vojtech Pavlik , Jiri Slaby , Chris J Arges , Andy Lutomirski , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v3 11/15] livepatch: use kstrtobool() in enabled_store() Message-ID: <20161216221942.mbtyq46kgs4fbraq@treble> References: <50c4817cbccd6e6cfd0c85c96bf127f84ee79cc8.1481220077.git.jpoimboe@redhat.com> <20161216165555.GK393@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161216165555.GK393@pathway.suse.cz> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 16 Dec 2016 22:19:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 05:55:55PM +0100, Petr Mladek wrote: > On Thu 2016-12-08 12:08:36, Josh Poimboeuf wrote: > > The sysfs enabled value is a boolean, so kstrtobool() is a better fit > > for parsing the input string since it does the range checking for us. > > > > Suggested-by: Petr Mladek > > Signed-off-by: Josh Poimboeuf > > --- > > kernel/livepatch/core.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > > index 6a137e1..8ca8a0e 100644 > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -408,26 +408,23 @@ static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, > > { > > struct klp_patch *patch; > > int ret; > > - unsigned long val; > > + bool enabled; > > > > - ret = kstrtoul(buf, 10, &val); > > + ret = kstrtobool(buf, &enabled); > > if (ret) > > return -EINVAL; > > I would return "ret" here. It is -EINVAL as well but... ;-) That was a preexisting issue with the kstrtoul() return code, but I'll sneak your suggested change into this patch if nobody objects. > Anyway, feel free to use: > > Reviewed-by: Petr Mladek > > Best Regards, > Petr -- Josh