From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933291AbcLQBiV (ORCPT ); Fri, 16 Dec 2016 20:38:21 -0500 Received: from server.atrad.com.au ([150.101.241.2]:47052 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758103AbcLQBiL (ORCPT ); Fri, 16 Dec 2016 20:38:11 -0500 X-Greylist: delayed 397 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Dec 2016 20:38:10 EST Date: Sat, 17 Dec 2016 12:00:07 +1030 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: fujitsu-laptop: set default trigger for radio LED to rfkill-any Message-ID: <20161217013007.GA12015@marvin.atrad.com.au> References: <20161216144603.19100-1-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161216144603.19100-1-kernel@kempniu.pl> User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMEDefang-action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 03:46:03PM +0100, Micha?? K??pie?? wrote: > The "radio components indicator" LED present in Lifebook E734/E744/E754 > should be lit when any radio transmitter is enabled, so set its default > trigger to rfkill-any. This shouldn't cause any problems. At the end of the day it's only the default; if for some reason it's inappropriate for any systems we could do an override. Acked-by: Jonathan Woithe > Signed-off-by: Micha?? K??pie?? > --- > Note: the rfkill-any trigger is currently only present in > mac80211-next/master. > > drivers/platform/x86/fujitsu-laptop.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index 61f39ab..bfc0eb3 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -202,6 +202,7 @@ static void radio_led_set(struct led_classdev *cdev, > > static struct led_classdev radio_led = { > .name = "fujitsu::radio_led", > + .default_trigger = "rfkill-any", > .brightness_get = radio_led_get, > .brightness_set = radio_led_set > };