linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: kbuild-all@01.org, MyungJoo Ham <myungjoo.ham@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	linux-kernel@vger.kernel.org,
	David Cohen <david.a.cohen@intel.com>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] extcon: 3gpio: add driver for USB OTG port controlled by 3 GPIOs
Date: Mon, 19 Dec 2016 10:34:11 +0800	[thread overview]
Message-ID: <201612191057.Ys3a3lG0%fengguang.wu@intel.com> (raw)
In-Reply-To: <20161219001220.13321-1-hdegoede@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 6560 bytes --]

Hi David,

[auto build test ERROR on chanwoo-extcon/extcon-next]
[also build test ERROR on v4.9 next-20161216]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/extcon-3gpio-add-driver-for-USB-OTG-port-controlled-by-3-GPIOs/20161219-082834
base:   https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git extcon-next
config: blackfin-allmodconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All error/warnings (new ones prefixed by >>):

>> drivers/extcon/extcon-3gpio_otg.c:185:1: warning: data definition has no type or storage class
    MODULE_DEVICE_TABLE(acpi, usb_otg_acpi_match);
    ^~~~~~~~~~~~~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:185:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>> drivers/extcon/extcon-3gpio_otg.c:185:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/acpi.h:27:0,
                    from drivers/extcon/extcon-3gpio_otg.c:21:
   include/linux/device.h:1353:1: warning: data definition has no type or storage class
    module_init(__driver##_init); \
    ^
>> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:197:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(usb_otg_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/device.h:1353:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
    module_init(__driver##_init); \
    ^
>> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:197:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(usb_otg_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-3gpio_otg.c:197:1: warning: parameter names (without types) in function declaration
   In file included from include/linux/acpi.h:27:0,
                    from drivers/extcon/extcon-3gpio_otg.c:21:
   include/linux/device.h:1358:1: warning: data definition has no type or storage class
    module_exit(__driver##_exit);
    ^
>> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:197:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(usb_otg_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/device.h:1358:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
    module_exit(__driver##_exit);
    ^
>> include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver'
     module_driver(__platform_driver, platform_driver_register, \
     ^~~~~~~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:197:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(usb_otg_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-3gpio_otg.c:197:1: warning: parameter names (without types) in function declaration
>> drivers/extcon/extcon-3gpio_otg.c:199:15: error: expected declaration specifiers or '...' before string constant
    MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-3gpio_otg.c:200:20: error: expected declaration specifiers or '...' before string constant
    MODULE_DESCRIPTION("3 GPIO USB OTG extcon driver");
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-3gpio_otg.c:201:16: error: expected declaration specifiers or '...' before string constant
    MODULE_LICENSE("GPL");
                   ^~~~~
   In file included from include/linux/acpi.h:27:0,
                    from drivers/extcon/extcon-3gpio_otg.c:21:
   drivers/extcon/extcon-3gpio_otg.c:197:24: warning: 'usb_otg_driver_exit' defined but not used [-Wunused-function]
    module_platform_driver(usb_otg_driver);
                           ^
   include/linux/device.h:1354:20: note: in definition of macro 'module_driver'
    static void __exit __driver##_exit(void) \
                       ^~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:197:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(usb_otg_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-3gpio_otg.c:197:24: warning: 'usb_otg_driver_init' defined but not used [-Wunused-function]
    module_platform_driver(usb_otg_driver);
                           ^
   include/linux/device.h:1349:19: note: in definition of macro 'module_driver'
    static int __init __driver##_init(void) \
                      ^~~~~~~~
>> drivers/extcon/extcon-3gpio_otg.c:197:1: note: in expansion of macro 'module_platform_driver'
    module_platform_driver(usb_otg_driver);
    ^~~~~~~~~~~~~~~~~~~~~~
   drivers/extcon/extcon-3gpio_otg.c:181:30: warning: 'usb_otg_acpi_match' defined but not used [-Wunused-variable]
    static struct acpi_device_id usb_otg_acpi_match[] = {
                                 ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +185 drivers/extcon/extcon-3gpio_otg.c

   179	}
   180	
   181	static struct acpi_device_id usb_otg_acpi_match[] = {
   182		{ "INT3496" },
   183		{ }
   184	};
 > 185	MODULE_DEVICE_TABLE(acpi, usb_otg_acpi_match);
   186	
   187	static struct platform_driver usb_otg_driver = {
   188		.driver = {
   189			.name = DRV_NAME,
   190			.owner = THIS_MODULE,
   191			.acpi_match_table = ACPI_PTR(usb_otg_acpi_match),
   192		},
   193		.probe = usb_otg_probe,
   194		.remove = usb_otg_remove,
   195	};
   196	
 > 197	module_platform_driver(usb_otg_driver);
   198	
 > 199	MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
   200	MODULE_DESCRIPTION("3 GPIO USB OTG extcon driver");
   201	MODULE_LICENSE("GPL");

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41983 bytes --]

  parent reply	other threads:[~2016-12-19  2:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19  2:01 [PATCH] extcon: 3gpio: add driver for USB OTG port controlled by 3 GPIOs kbuild test robot
2016-12-19  0:12 ` Hans de Goede
2016-12-19  1:57   ` kbuild test robot
2016-12-19  2:01   ` [PATCH] extcon: 3gpio: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-12-19  2:34   ` kbuild test robot [this message]
2016-12-19  8:00   ` [PATCH] extcon: 3gpio: add driver for USB OTG port controlled by 3 GPIOs Chanwoo Choi
2016-12-19  8:57     ` Hans de Goede
2016-12-19  9:41       ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201612191057.Ys3a3lG0%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=cw00.choi@samsung.com \
    --cc=david.a.cohen@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).