From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbcLSWMw (ORCPT ); Mon, 19 Dec 2016 17:12:52 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:36727 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764AbcLSWMu (ORCPT ); Mon, 19 Dec 2016 17:12:50 -0500 Date: Mon, 19 Dec 2016 16:12:47 -0600 From: Rob Herring To: Sebastien Bourdelin Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@savoirfairelinux.com, mark@embeddedarm.com, kris@embeddedarm.com, horms+renesas@verge.net.au, treding@nvidia.com, jonathanh@nvidia.com, f.fainelli@gmail.com, fabio.estevam@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux@armlinux.org.uk, linux@roeck-us.net, wim@iguana.be, mark.rutland@arm.com, damien.riegel@savoirfairelinux.com, lucile.quirion@savoirfairelinux.com, olof@lixom.net, arnd@arndb.de, suzuki.poulose@arm.com, linus.walleij@linaro.org, will.deacon@arm.com, yamada.masahiro@socionext.com Subject: Re: [PATCH 3/6] dt-bindings: bus: Add documentation for the Technologic Systems NBUS Message-ID: <20161219221247.cgcvssqo23qyslyj@rob-hp-laptop> References: <20161214231237.17496-1-sebastien.bourdelin@savoirfairelinux.com> <20161214231237.17496-4-sebastien.bourdelin@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161214231237.17496-4-sebastien.bourdelin@savoirfairelinux.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 06:12:33PM -0500, Sebastien Bourdelin wrote: > Add binding documentation for the Technologic Systems NBUS that is used > to interface with peripherals in the FPGA of the TS-4600 SoM. > > Signed-off-by: Sebastien Bourdelin > --- > Documentation/devicetree/bindings/bus/ts-nbus.txt | 50 +++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/bus/ts-nbus.txt > > diff --git a/Documentation/devicetree/bindings/bus/ts-nbus.txt b/Documentation/devicetree/bindings/bus/ts-nbus.txt > new file mode 100644 > index 0000000..2f777ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/bus/ts-nbus.txt > @@ -0,0 +1,50 @@ > +Technologic Systems NBUS > + > +The NBUS is a bus used to interface with peripherals in the Technologic > +Systems FPGA on the TS-4600 SoM. > + > +Required properties : > + - compatible : "technologic,ts-nbus", "simple-bus" > + - #address-cells : must be 1 > + - #size-cells : must be 0 > + - pws : The PWM pin connected to the clock line on the FPGA Using PWM binding? > + - data-gpios : The GPIO pin connected to the data line on the FPGA > + - csn-gpios : The GPIO pin connected to the csn line on the FPGA > + - txrx-gpios : The GPIO pin connected to the txrx line on the FPGA > + - strobe-gpios : The GPIO pin connected to the stobe line on the FPGA > + - ale-gpios : The GPIO pin connected to the ale line on the FPGA > + - rdy-gpios : The GPIO pin connected to the rdy line on the FPGA These all need vendor prefix. This is not any sort of standard bus? > + > +Child nodes: > + > +The NBUS node can contain zero or more child nodes representing peripherals > +on the bus. > + > +Example: > + > + nbus { > + compatible = "technologic,ts-nbus", "simple-bus"; I don't think simple-bus is really valid here. Don't you need the nbus driver before the devices are usable? > + pinctrl-0 = <&nbus_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + pwms = <&pwm 2 83>; > + data-gpios = <&gpio0 0 GPIO_ACTIVE_HIGH > + &gpio0 1 GPIO_ACTIVE_HIGH > + &gpio0 2 GPIO_ACTIVE_HIGH > + &gpio0 3 GPIO_ACTIVE_HIGH > + &gpio0 4 GPIO_ACTIVE_HIGH > + &gpio0 5 GPIO_ACTIVE_HIGH > + &gpio0 6 GPIO_ACTIVE_HIGH > + &gpio0 7 GPIO_ACTIVE_HIGH>; > + csn-gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>; > + txrx-gpios = <&gpio0 24 GPIO_ACTIVE_HIGH>; > + strobe-gpios = <&gpio0 25 GPIO_ACTIVE_HIGH>; > + ale-gpios = <&gpio0 26 GPIO_ACTIVE_HIGH>; > + rdy-gpios = <&gpio0 21 GPIO_ACTIVE_HIGH>; > + > + wdt@2a { watchdog@... > + compatible = "..."; > + > + /* ... */ > + }; > + }; > -- > 2.10.2 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html