From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755643AbcLTLr1 (ORCPT ); Tue, 20 Dec 2016 06:47:27 -0500 Received: from mail-ve1eur01hn0220.outbound.protection.outlook.com ([104.47.1.220]:54880 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751970AbcLTLrX (ORCPT ); Tue, 20 Dec 2016 06:47:23 -0500 X-Greylist: delayed 6949 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 Dec 2016 06:47:23 EST Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rkagan@virtuozzo.com; Date: Tue, 20 Dec 2016 13:01:55 +0300 From: Roman Kagan To: Paolo Bonzini CC: Denis Plotnikov , , , Subject: Re: [RFC PATCH v3 0/6] KVM: x86: avoid redundant REQ_EVENT Message-ID: <20161220100155.GF2081@rkaganb.sw.ru> Mail-Followup-To: Roman Kagan , Paolo Bonzini , Denis Plotnikov , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com References: <1482140838-6303-1-git-send-email-pbonzini@redhat.com> <672a23fe-3df7-dd1b-27ee-4b453ca33236@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <672a23fe-3df7-dd1b-27ee-4b453ca33236@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR0501CA0038.eurprd05.prod.outlook.com (10.167.83.176) To HE1PR0802MB2474.eurprd08.prod.outlook.com (10.175.34.147) X-MS-Office365-Filtering-Correlation-Id: f5d4c774-11c4-4e48-a0e3-08d428bf3ebe X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0802MB2474; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2474;3:/UkRTJV9+zhY9lUPbMi5EnF8J/poCdD4N1vF49hrGFSgBtWSWJuz57kD8TKkjZa79iY7ECiPMqrmhpSvj6L0kM6K1fXrkNM+oPJ1eFVU9+OzndABK8rNG2au5HA4UADXunjY7IN94twdN1b0lmI2czOB6YMr1b1SsZ5U8xm8qbowAU7WQ5PUArCIPCQnXPe29e4oWfyW2Rd0PeOcx6z1HwWK8koAAmmalnbwhe6e+EJoy/3vUNVKM4Y1YVGiqilE7TPOHunkOMcZEUBIF8LxRw==;25:yc5+BTknzqGCGrHXOUmBJSwWXtX/DXHs5Bn3pROFmAG7UvjRr1IiLTIlI8mZfMVK5wNJfM5rjfnAVMhpn1guF5wzWcDWifx6InilnXmAuacZ6rr5RO6kP83ZhsHOopaV9uybgjudH4ZQXQvOqJTRyR/kJ/D8H89TZyiTZE8gHUAmwd0YOwHB2SiM5KaKmqRzu+d+Va3PfMF6+rTfalJCz8udESDjKkLrv/mFkKlLsviSA1xjE2Tx1oicfCC2YWu91vVj8IuWyQ0pkmi+SFNilFN2qCZtmGQ0E3Ar5SN++oVfUZcsxMbRf6IC/dJHe7DeSOvtntDNxqYJ260Z16GqRZmXvR70b8DO6f6ueW6taVuGSeALv6OBCHdhRMoMEvfAau4NkXxM2RF/39jDR0ByRqlv1q0TO/7vUvuW3cy3vQ2EVa48fdboatz4A5g1g+hI1jPVY02OeNWZjeLzX4txSA== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2474;31:tlYoGMGjuA6xhtvJ4fdqOeDbqFdI8vONsbuBTVpt+Fvj3iL+RmCbrzl1fpdEQ/Su8ePzAGCFcb/JZNZs0++ChJTrGQo0zgC/j3JvjTr0h1uANiVeaAg05sfkP1i3W6TnoPhx4s6M+6MGKSC1swcPQK9zzQ/YB8lgfB4KAvMCFM3zEk/dFqc9OwYTp5GPK1O/gyuGX6OY+epFXARawjq49zPtx5bST1UsHpqFmI9ZUmQDqXbmbvfXhSyH1ubi8u45;20:pnQ5zGL6a76sGddA7Cf13er8Sf+z67S5DYhlcvu+MmOruKPAY2Z9dKMmN/pZbzGo5t1sGmsovHnarhMN0ZulbvBC+RpQ72CH/sywBVnJ2kFqKHdz4lXvC3mjdjEV1+8SQRAbwbvSGyx1PWqkpOSwTyRY6Lb4znDfQY4ieEyOr52TluStQpJU2anBbfZ0v3W0b5anbqleSXCZwOl+urnEwk2YcqywDA69Ly058xSxqylVFDjkp7z2l7Hk7Llukvxx X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:HE1PR0802MB2474;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0802MB2474; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2474;4:MxWJOMA+KIVELHD2QDbp6ZRVFCP4anPGs3RsMWejfdG6gqXt6MYBh92DlJr1L+PpAus0SvoquZAiXbP5gtWaklRpCqHdfNEiqDujV1qQILU949hTa4AOZQD34bJJeIlQhoaUPBdKhW8ZvHSwh89JZwHWkp7WxMmWcae1KLGjFyxmVCtDQTignGrBdJBG+yVFXQJReDkqlUuDA5mzhPk/YZiCV1a9R3XTXognTfT96PGimxUSMBbejjYEx83nhRMoKz47UWstHpmplQB9gmvWF4IKmBf3KFjw6j+XKfN4/k0oHUmpoQi752yNVWEv5cWbBwk//SOhDuqmVaRELAJ34l3OgAr5sXqF1bSw9YQmwPVlhQaAPdmsGihl6M45Jb3klspIwb2+prmcx9IbiMhh/Ytda0cVWhgWa+5z99T0HLHIeyAfRdhKPYEpQ24AZyrZP7gMKnfcUNPh0Dg2wkp8CHL5W4UBpGYvwpZzHCex1qVCMV2zcDw5LQDbSR7xBL8TXByDlB8gItEl39sV8VB9gYNUbdquY3kfYdFgcH0XjllOr6k9VU8EQx/HBl3uhRsVf7c6xKT0+stJxXjCbvny3mavziccIygm+1+E0j3Vavi3XuIv74I/cBkPtDug8vxD X-Forefront-PRVS: 0162ACCC24 X-Forefront-Antispam-Report: SFV:SPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39410400002)(39830400002)(39450400003)(24454002)(189002)(199003)(189998001)(76176999)(229853002)(54356999)(50986999)(9686002)(36756003)(92566002)(97736004)(25786008)(6506006)(110136003)(86362001)(105586002)(97756001)(106356001)(47776003)(66066001)(42186005)(68736007)(4001350100001)(6666003)(6916009)(53416004)(2950100002)(81156014)(46406003)(81166006)(8676002)(38730400001)(4326007)(5660300001)(23726003)(1076002)(83506001)(69596002)(3846002)(6116002)(7736002)(101416001)(2906002)(33656002)(305945005)(50466002)(30126002);DIR:OUT;SFP:1501;SCL:5;SRVR:HE1PR0802MB2474;H:rkaganb.sw.ru;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0802MB2474;23:W9tAMBjubxA9mnqM4oRkvoyzArgUFEaWbEdLSSk?= =?us-ascii?Q?YmlboW0bakMFxwRyYkerT+eqy8oHWywFVY/uMXp6suOADSaSNE4E+05OSNh2?= =?us-ascii?Q?ERHZbikiTlkK3eqrTKNY/WhuRBIx0189d+du7Rd50sQnH3HLtAbOTKWmjemu?= =?us-ascii?Q?PARbju9W8sQse0lOcTpd3mZXHw0G64s1wCZa1EQlxftJgIKYznDvjcWD20Kx?= =?us-ascii?Q?ObD4ik4uQ/LFkv6X9gEdIfUI+jlqDq4tP54fEJGLSaPN3cOO5aq2Z37YYbqV?= =?us-ascii?Q?UV1cEJBrUFohV24lcTE01mxqEZX6vOYTPp21uQ4Js6Myfan0RyQ7+ZHDDzWM?= =?us-ascii?Q?HXsKSsQVEgH41DdhtjDv1oxsa8MB5UER1hT/5hWEhBeaqyEGybu4URywkP1J?= =?us-ascii?Q?xyB9I1EIXne6ueQSHxp2QfWkbxk9Y1LBQDXGSpqzvgkCRzjxBnCqxjaDycGG?= =?us-ascii?Q?+jkhdj2oYkGwxHZVB+U2iU+AZijxwMY/lR43Nkbyx/aMOv/nsQ01HdAF6KVi?= =?us-ascii?Q?m24L2ExqR4cgJij9YvyRoyTxFHfzvTp/JE43ZlgCSa5v3L5em1YlOSIqqxuf?= =?us-ascii?Q?eBXRreG8ysjq1FJhk4mHxajFLYMZuKvAiRtaFJkjPGXI6145USVmxOkSRIfS?= =?us-ascii?Q?8qtKj8m7Q+Ea2mVghvAP7+Sk4uLijFUwcGuejl+KaZMv66JyBnfdROkCt5SK?= =?us-ascii?Q?gV5P1qHSBmDptuAEgU2optVzMGjnp3GAlm7rX6ptynDyzFJp/bm/Y8xB9VNW?= =?us-ascii?Q?kRRD4Qi2/q/J1frfn8c5e5K+dFRYFDD0ADHz/SG27s1qzMf0bRnNNbhLqsP6?= =?us-ascii?Q?IptFaYfv4Au+KcJeheaOEGEHS8TdnMqT/xNdv7vdAPBhOh2dBuTjZgq/5s6A?= =?us-ascii?Q?VDPItqZjZhrpDbgaJ+7aMgFdE5Oj+lt+hfMff/tOtUBnc6MTQ2T5Zz3g9lZj?= =?us-ascii?Q?lYyWhnuIFyqEaOvWxT78VrzyJ1StmLBrkITSLGMp3lJw424JQMUOj32G/vMV?= =?us-ascii?Q?NI89x/WmkPjG0U+0QHFUlEnc8O05B3bEZIwNYnVVNzSYjV+oYpvRvxWVDH/D?= =?us-ascii?Q?E+kqxPK8gBld1XcjWtlIo4METcqsyiuCOXwIpcMSnvFlFQLSOpXf1tXr5nH0?= =?us-ascii?Q?4MbeW8JQnsq3WDY5h/NtHTk8UYc1vG8CWCr0ML+yJiupuG2acxcFi/4xcIga?= =?us-ascii?Q?qRCcH0QApS0BhvnxRHaf6Vm09sQjsENEDTiB8mPUjKwTf61yNwYmx/dEsi9b?= =?us-ascii?Q?FuSd/7SqqHJ0jOso5vygEzrRVmHwiZ3k6JZDLAyAcWCDNCCW62aXdbtx1jDs?= =?us-ascii?Q?e6iLW1pcMBEqMwmtdlR0LsVHyKzKdwbfW4IumzkQBicAl?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2474;6:ONn4XGfBulniPZj0Gqjmp6tIbyypNdMtLutPWJwuxVHQDrvylCa4IF7SgFfKxqV6rHTQlfY+l+/fuB8RF+yvIphgsPUVdpJkCik0hb+XDjJOfpoG7hE3Sn46uiM84QU8EHZmj1LkbSGawCYu/A1FHYxxmNuQpc+l4qlJ6ETq5/iTYuMDioBF/tbb1LGcMONuz/DP8whEHoNi/LIhoa6ZRgr7EUT4pNKwRk3fP0h2TAphvIlpDRwwV8A+QGgyBaP0oHGC9gIR2as9q20ZoxpDT30Sae9b1DPLh8O6BdQZhDvUUs1pbgtt2iUIlS9GLcWIKEb5QVUJVTPNd2lxuKLMGnl/kyii9kGQMTmNDHhPQSO+Uhxqm3neHtT3dQGyfspSXSSWOT7B8unc9NCIkyxysZUiDT/o9lcMdv7c/xXelhQ=;5:i6Xn629zapt8pKKDt1opvrfMyXQrUZkqGB4bgx0jEfo1+sf05xjcK11gNKpJmLSZIaKM5BV8sSzaZOcrtDRNJdnkV2lRoIQS3GxY/P6RsAeBRi4bYrKHPQqpHtZqyWxSfme3av8apbfWH2yn1ERvow==;24:bGf3y3f2giz5E0ir0ErDX9WSD45gw1Dc3j/OXVl1oIaD6LR28lfTIrjhFWTyH7lgiOOgjZG566L6TL3TP2TJzw== SpamDiagnosticOutput: 1:22 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0802MB2474;7:SwWOVQntb7IbzTwZUFIgC7GkFFkXBzoSBy2gBb+3s/tlu8WISXQuQLF70lskMJB/ReyKu+9+gBTagxMdRyqA3nyPkhEGj6SR/HL9sHMflPvayPEuqMKddbNCiGqApqan4PNCgd4R3a4KtJS1tIWLrDIXtnJaA6pCcpE6ZoKwOBmJoN2e48zkY/OoRo6o5aZnbQyj0UScesR2bQFl0P7fp3baMMSB4r/d5+Qfy29iL/q30s01NQMdAEUgA4KbJBY774l0kVb2pmB2Mplyhgqm5kWFEiGzmUXAOKaPALh/+eYPfHOi9JZLxPESpRo6Sh1SEfpWDgzQlB0BzSnLtCqSA87WEHSZn/5V+WZlot1WZrGQFLj3kU7ZwZjynPHm3yIzw15jhX7DeOOSJQig4Sl38XnJraht/bJmA2zBp/Sow34bOD27jpvlPCDTrEyHoJqZ7ZoMW/OAiI7v9/MGnfTzhA==;20:DUutLnqwwL+0l23aj9vZsCJAQw55W7Q8mEarZzLSx4swV0oWuADIsE5Noithq6xHpuimLvE0X7QlBy8ViHAAgmzCkaH57buvr/t+bHFRKCGvxWSEYeNrjqkVr+NUHpMhoZ3Y/SBMEl66N8r81+qbDO74xm36RRWJ+ZFozb6r9oc= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 10:02:01.6572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2474 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2016 at 03:30:17PM +0100, Paolo Bonzini wrote: > > > On 19/12/2016 14:05, Denis Plotnikov wrote: > >> > > This new patch-set does avoid unnecessary interrupt re-injections - > > checked. > > > > The test (MS Windows, sending messages between multiple windows using > > windows-specific interface), > > which showed performance growth with "[PATCH v2] KVM: x86: avoid > > redundant REQ_EVENT" showed pretty much the same performance level with > > this new patch-set. > > The test score difference (+2.4% to [PATCH v2]) is within the tolerance > > range(5%). > > > > The test score on mainstream v4.9 kernel CPU Intel i5-2400, guest > > Windows Server 2012 2VCPU, 2GB: > > > > without patch: 31510 (+/- 4%) > > with patch: 36270 (+/- 5%) > > > > difference = (36270-31510)/31510 * 100 = +15% -- looks good! > > Awesome! I hope it also qualifies as less ugly. :) Absolutely. FWIW Reviewed-by: Roman Kagan Roman.