Hi! > I think WARN() is good. It's a driver bug and it deserves to be notified. ... > I guess it's been like this since 2008 or so. I guess the comment could be > simply removed, it's not a real problem. ... > AFAIR the module is called Stingray. Ok, so it seems we are pretty good? Can you take the patch now? Device tree documentation is in Subject: [PATCH v6] media: et8ek8: add device tree binding documentation and we have Acked-by: Rob Herring on that. Thanks and best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html