archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <>
To: <>
Subject: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c
Date: Tue, 20 Dec 2016 16:16:23 -0500	[thread overview]
Message-ID: <> (raw)

In commit d47529b2e9fe0ec2eb1f072afad8849f52e385c4 ("gpio: don't
include module.h in shared driver header") we fixed a bunch of
implicit includes and then did what the shortlog says -- remove
module.h from a gpio header.

In parallel, commit 024366750c2e04fdcda8bca685194ef0196b35fe
("mtd: nand: xway: convert to normal platform driver") added new
modular function calls to a file that now became relying on the
above module.h presence in the gpio header, since it did not
explicitly include module.h header for them as part of the change.

The problem only appears when the two dev streams are merged.

Since the file is tristate, the fix is obvious -- it needs an
explicit include of module.h header.

Reported-by: kbuild test robot <>
Cc: Hauke Mehrtens <>
Cc: Boris Brezillon <>
Cc: Linus Walleij <>
Cc: Alexandre Courbot <>
Signed-off-by: Paul Gortmaker <>
 drivers/mtd/nand/xway_nand.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
index 1f2948c0c458..00168d633bcf 100644
--- a/drivers/mtd/nand/xway_nand.c
+++ b/drivers/mtd/nand/xway_nand.c
@@ -7,6 +7,7 @@
  *  Copyright © 2016 Hauke Mehrtens <>
+#include <linux/module.h>
 #include <linux/mtd/nand.h>
 #include <linux/of_gpio.h>
 #include <linux/of_platform.h>

             reply	other threads:[~2016-12-20 21:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20 21:16 Paul Gortmaker [this message]
2016-12-20 21:18 Paul Gortmaker
2016-12-21 15:19 ` Hauke Mehrtens
2016-12-21 17:44   ` Paul Gortmaker
2016-12-22  9:01   ` Boris Brezillon
2016-12-24 17:18     ` Hauke Mehrtens
2016-12-21 23:27 ` kbuild test robot
2016-12-24 17:19   ` Hauke Mehrtens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --subject='Re: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).