linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Imran Khan <kimran@codeaurora.org>
Cc: andy.gross@linaro.org, lee.jones@linaro.org,
	David Brown <david.brown@linaro.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org
Subject: Re: [PATCH v6] soc: qcom: Add SoC info driver
Date: Tue, 20 Dec 2016 14:50:07 -0800	[thread overview]
Message-ID: <20161220225007.GD5423@codeaurora.org> (raw)
In-Reply-To: <05cdb699-6406-cff8-cce6-fcedf6ac6c4e@codeaurora.org>

On 12/18, Imran Khan wrote:
> 
> I had discussed this with Bjorn and it was recommended to keep it out of 
> smem.h. If needed I can move it back there.

Ok no worries from me then if this has already been discussed.

> 
> Yes. The numbers used here can have different meaning for different ODMs.
> But these attributes (hw_patform type/subtype etc.) are outside the
> generic soc_device_attribute so I think the interpretation of these numbers
> can very well be ODM specific. We can try to keep only those types here that
> are relevant for newer platforms but we intend to keep these attributes
> nonetheless.

I'll wait to see what the next patch version has. We will
probably need to have some way to know which ODM the kernel is
running on, so we can interpret the platform type/subtype fields
properly. That part seems to be lacking from this patch right
now. We assume it's always qcom as the ODM, which isn't true.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2016-12-20 22:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 15:17 [PATCH v6] soc: qcom: Add SoC info driver Imran Khan
2016-12-13 19:17 ` Bjorn Andersson
2016-12-14  0:26 ` Stephen Boyd
2016-12-15 16:29   ` Imran Khan
2016-12-17  1:26     ` Stephen Boyd
2016-12-18 18:12       ` Imran Khan
2016-12-20 22:50         ` Stephen Boyd [this message]
2016-12-21  7:10           ` Imran Khan
2016-12-22  0:31             ` Stephen Boyd
2016-12-22 21:23               ` Imran Khan
2016-12-28 22:35                 ` Stephen Boyd
2016-12-29  5:46                   ` Imran Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161220225007.GD5423@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=kimran@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).