From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756228AbcLUHVW (ORCPT ); Wed, 21 Dec 2016 02:21:22 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36516 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754262AbcLUHVU (ORCPT ); Wed, 21 Dec 2016 02:21:20 -0500 Date: Wed, 21 Dec 2016 07:49:50 +0100 From: Michal Hocko To: Thomas Casey Cc: akpm@linux-foundation.org, john.stultz@linaro.org, tglx@linutronix.de, gorcunov@openvz.org, nicolas.pitre@linaro.org, skinsbursky@virtuozzo.com, mguzik@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call Message-ID: <20161221064950.GA16502@dhcp22.suse.cz> References: <20161220143919.GA2334@loonix.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161220143919.GA2334@loonix.localdomain> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 20-12-16 14:39:19, Thomas Casey wrote: > Fixes two instances of EXPORT_SYMBOL not being called immediately after > the initialization of its argument What does this fix actually? > Signed-off-by: Thomas Casey > --- > kernel/sys.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/kernel/sys.c b/kernel/sys.c > index 9758892a2d09..8afd3e341f9b 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -110,9 +110,8 @@ > */ > > int overflowuid = DEFAULT_OVERFLOWUID; > -int overflowgid = DEFAULT_OVERFLOWGID; > - > EXPORT_SYMBOL(overflowuid); > +int overflowgid = DEFAULT_OVERFLOWGID; > EXPORT_SYMBOL(overflowgid); > > /* > @@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid); > */ > > int fs_overflowuid = DEFAULT_FS_OVERFLOWUID; > -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID; > - > EXPORT_SYMBOL(fs_overflowuid); > +int fs_overflowgid = DEFAULT_FS_OVERFLOWUID; > EXPORT_SYMBOL(fs_overflowgid); > > /* > -- > 2.11.0 > -- Michal Hocko SUSE Labs