linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: John Crispin <john@phrozen.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH] pci: add kernel config option for disabling common PCI quirks
Date: Wed, 21 Dec 2016 11:19:15 +0100	[thread overview]
Message-ID: <20161221101915.GC14781@wunner.de> (raw)
In-Reply-To: <1482306784-29224-1-git-send-email-john@phrozen.org>

On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote:
> From: Gabor Juhos <juhosg@openwrt.org>
> 
> These quirks do not effect small small plastic routers. These routers tend
> to have very little flash space. This patch adds a new option that allows
> us to build a kernel without including the common quirks, thus saving us
> valuable flash space.
> 
> When building an image for a MIPS/Ralink router with this option enabled
> it will reduce the size of an uncompressed uImage by 12KB.

There's already a PCI_QUIRKS config option defined in init/Kconfig,
why isn't this sufficient?  Do you want *some* quirks but not others?

Thanks,

Lukas

  reply	other threads:[~2016-12-21 10:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21  7:53 [PATCH] pci: add kernel config option for disabling common PCI quirks John Crispin
2016-12-21 10:19 ` Lukas Wunner [this message]
2016-12-21 12:22 ` Christoph Hellwig
2016-12-21 13:11   ` John Crispin
2016-12-21 14:26     ` Christoph Hellwig
2016-12-22  5:54       ` John Crispin
2016-12-22 18:45         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161221101915.GC14781@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=john@phrozen.org \
    --cc=juhosg@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).