linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: John Crispin <john@phrozen.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH] pci: add kernel config option for disabling common PCI quirks
Date: Wed, 21 Dec 2016 04:22:13 -0800	[thread overview]
Message-ID: <20161221122213.GA32563@infradead.org> (raw)
In-Reply-To: <1482306784-29224-1-git-send-email-john@phrozen.org>

On Wed, Dec 21, 2016 at 08:53:04AM +0100, John Crispin wrote:
> This patch has been lingering inside the OpenWrt for some years. I am not
> sure if this is the best way to remove the quirks from the build. Let me
> know if you prefer a different way of solving this.

As a start negative options (_DISABLE_) are very confusing, I would
recommend to turn this into a postive option with a default y.

On what grounds did you decide which quirks to keep and which to
remove?

  parent reply	other threads:[~2016-12-21 12:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21  7:53 John Crispin
2016-12-21 10:19 ` Lukas Wunner
2016-12-21 12:22 ` Christoph Hellwig [this message]
2016-12-21 13:11   ` John Crispin
2016-12-21 14:26     ` Christoph Hellwig
2016-12-22  5:54       ` John Crispin
2016-12-22 18:45         ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161221122213.GA32563@infradead.org \
    --to=hch@infradead.org \
    --cc=bhelgaas@google.com \
    --cc=john@phrozen.org \
    --cc=juhosg@openwrt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --subject='Re: [PATCH] pci: add kernel config option for disabling common PCI quirks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).