From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934759AbcLUNZx (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Dec 2016 08:25:53 -0500
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:33457 "EHLO
        metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S934368AbcLUNZu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Dec 2016 08:25:50 -0500
Date: Wed, 21 Dec 2016 14:25:19 +0100
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        Russell King <linux@armlinux.org.uk>, Stefan Agner <stefan@agner.ch>,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        andrew@lunn.ch, Sascha Hauer <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>, cphealy@gmail.com
Subject: Re: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link'
 from DSA ports
Message-ID: <20161221132519.bkkqyfk3beow7nc5@pengutronix.de>
References: <1482131877-6097-3-git-send-email-andrew.smirnov@gmail.com>
 <1482325125-15725-1-git-send-email-nikita.yoush@cogentembedded.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1482325125-15725-1-git-send-email-nikita.yoush@cogentembedded.com>
User-Agent: Mutt/1.6.2-neo (2016-06-11)
X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote:
> > Remove 'fixed-link' nodes from DSA ports since they are not needed (they
> > are not limiting link's speed and the ports will be configured to their
> > maximux speed as a default)
> >
> > Suggested-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> 
> With this patch, ports connected to revB's second switch stop working.

This is probably because without a fixed-link node the phy-mode setting
isn't applied by the driver.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |