From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934104AbcLUOfX (ORCPT ); Wed, 21 Dec 2016 09:35:23 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42040 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbcLUOfV (ORCPT ); Wed, 21 Dec 2016 09:35:21 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org D543A61655 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: rtlwifi: Fix kernel oops introduced with commit e49656147359 From: Kalle Valo In-Reply-To: <20161220023812.5999-1-Larry.Finger@lwfinger.net> References: <20161220023812.5999-1-Larry.Finger@lwfinger.net> To: Larry Finger Cc: Linus Torvalds , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Larry Finger , linux-kernel@vger.kernel.org, driver-devel@vger.kernel.org, Stable , Wei Yongjun User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.3 Message-Id: <20161221143520.5873D61662@smtp.codeaurora.org> Date: Wed, 21 Dec 2016 14:35:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Larry Finger wrote: > With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of > kfree_skb"), the method used to free an skb was changed because the > kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb() > guards against a NULL value for the argument. Routine dev_kfree_skb_irq() > does not, and a test is needed to prevent kernel panics. > > Fixes: e49656147359 ("rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb") > Signed-off-by: Larry Finger > Cc: Stable # 4.9+ > Cc: Wei Yongjun Patch applied to wireless-drivers.git, thanks. 22b68b93ae25 rtlwifi: Fix kernel oops introduced with commit e49656147359 -- https://patchwork.kernel.org/patch/9481055/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches