From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758525AbcLVASx (ORCPT ); Wed, 21 Dec 2016 19:18:53 -0500 Received: from ns.sciencehorizons.net ([71.41.210.147]:41017 "HELO ns.sciencehorizons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754433AbcLVASn (ORCPT ); Wed, 21 Dec 2016 19:18:43 -0500 Date: 21 Dec 2016 19:18:11 -0500 Message-ID: <20161222001811.7109.qmail@ns.sciencehorizons.net> From: "George Spelvin" To: linux@sciencehorizons.net, tytso@mit.edu Subject: Re: HalfSipHash Acceptable Usage Cc: ak@linux.intel.com, davem@davemloft.net, David.Laight@aculab.com, djb@cr.yp.to, ebiggers3@gmail.com, eric.dumazet@gmail.com, hannes@stressinduktion.org, Jason@zx2c4.com, jeanphilippe.aumasson@gmail.com, kernel-hardening@lists.openwall.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, luto@amacapital.net, netdev@vger.kernel.org, tom@herbertland.com, torvalds@linux-foundation.org, vegard.nossum@gmail.com In-Reply-To: <20161221222702.h2vboms776zpgpi4@thunk.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Theodore Ts'o wrote: > On Wed, Dec 21, 2016 at 01:37:51PM -0500, George Spelvin wrote: >> SipHash annihilates the competition on 64-bit superscalar hardware. >> SipHash dominates the field on 64-bit in-order hardware. >> SipHash wins easily on 32-bit hardware *with enough registers*. >> On register-starved 32-bit machines, it really struggles. > And "with enough registers" includes ARM and MIPS, right? Yes. As a matter of fact, 32-bit ARM does particularly well on 64-bit SipHash due to its shift+op instructions. There is a noticeable performance drop, but nothing catastrophic. The main thing I've been worried about is all the flow tracking and NAT done by small home routers, and that's addressed by using HalfSipHash for the hash tables. They don't *initiate* a lot of TCP sessions. > So the only > real problem is 32-bit x86, and you're right, at that point, only > people who might care are people who are using a space-radiation > hardened 386 --- and they're not likely to be doing high throughput > TCP connections. :-) The only requirement on performance is "don't make DaveM angry." :-) I was just trying to answer the question of why we *worried* about the performance, not specifically argue that we *should* use HalfSipHash.