From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1764270AbcLWHRg (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Dec 2016 02:17:36 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53047 "EHLO
        out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1755831AbcLWHRf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2016 02:17:35 -0500
X-ME-Sender: <xms:js9cWJf-ATqIFu0gCn3hF-UZgdgYCNs6vFB4svWW_NV_rmOicVoAVg>
X-Sasl-enc: nc0ILLgmZT6JSzeY5DX0hCvlsTzGMmk2EHWLUTl9GhyA 1482477453
Date: Fri, 23 Dec 2016 08:17:48 +0100
From: Greg KH <greg@kroah.com>
To: greg@enjellic.com
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
        xen-users@lists.xen.org, stable@vger.kernel.org, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH] tpm: Restore functionality to xen vtpm driver.
Message-ID: <20161223071748.GA23493@kroah.com>
References: <201612222041.uBMKfqKC018662@wind.enjellic.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201612222041.uBMKfqKC018662@wind.enjellic.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 22, 2016 at 02:41:52PM -0600, Dr. Greg Wettstein wrote:
> Functionality of the xen-tpmfront driver was lost secondary to
> the introduction of xenbus multi-page support in the following
> commit:
> 
> ccc9d90a9a8b5c4ad7e9708ec41f75ff9e98d61d
> 
> xenbus_client: Extend interface to support multi-page ring
> 
> In this commit a pointer to the shared page address was being
> passed to the xenbus_grant_ring() function rather then the
> address of the shared page itself.  This resulted in a situation
> where the driver would attach to the vtpm-stubdom but any attempt
> to send a command to the stub domain would timeout.
> 
> A diagnostic finding for this regression is the following error
> message being generated when the xen-tpmfront driver probes for a
> device:
> 
> <3>vtpm vtpm-0: tpm_transmit: tpm_send: error -62
> 
> <3>vtpm vtpm-0: A TPM error (-62) occurred attempting to determine the timeouts
> 
> This fix is relevant to all kernels from 4.1 forward which is the
> release in which multi-page xenbus support was introduced.
> 
> Daniel De Graaf formulated the fix by code inspection after the
> regression point was located.
> 
> Signed-off-by: Dr. Greg Wettstein <greg@enjellic.com>

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>