From: Mark Greer <mgreer@animalcreek.com>
To: Geoff Lansberry <geoff@kuvee.com>
Cc: linux-wireless@vger.kernel.org, lauro.venancio@openbossa.org,
aloisio.almeida@openbossa.org, sameo@linux.intel.com,
robh+dt@kernel.org, mark.rutland@arm.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
justin@kuvee.com, Jaret Cantu <jaret.cantu@timesys.com>
Subject: Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel
Date: Fri, 23 Dec 2016 23:01:41 -0700 [thread overview]
Message-ID: <20161224060141.GA9069@animalcreek.com> (raw)
In-Reply-To: <1482380314-16440-3-git-send-email-geoff@kuvee.com>
On Wed, Dec 21, 2016 at 11:18:34PM -0500, Geoff Lansberry wrote:
> From: Jaret Cantu <jaret.cantu@timesys.com>
>
> Repeated polling attempts cause a NULL dereference error to occur.
> This is because the state of the trf7970a is currently reading but
> another request has been made to send a command before it has finished.
>
> The solution is to properly kill the waiting reading (workqueue)
> before failing on the send.
>
> Signed-off-by: Geoff Lansberry <geoff@kuvee.com>
> ---
You've still provided virtually no information on the actual problem(s)
nor justified why you think this is the best solution. You're adding
code to a section of code that should _never_ be executed so the only
reasonable things I can infer is that there are, at least, two problems:
1) There is a bug causing execution to get into this block of code.
2) Once in this block of code, there is another bug.
You seem to be attempting to fix 2) and completely ignoring 1).
1) is the first bug that needs to be root-caused and fixed.
Also, what exactly is the "NULL dereference error" you mention?
Is this the neard crash you talked about in another thread or is
this a kernel crash? If it is the kernel crash, please post the
relevant information. If this is the neard crash - which seems
unlikely - then how can changing a section of kernel code that
shouldn't be executed in the first place fix that?
Mark
--
next prev parent reply other threads:[~2016-12-24 6:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 4:18 [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock Geoff Lansberry
2016-12-22 4:18 ` [PATCH v3 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Geoff Lansberry
2016-12-22 23:02 ` Rob Herring
2017-01-20 18:37 ` Mark Greer
2016-12-22 4:18 ` [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel Geoff Lansberry
2016-12-24 6:01 ` Mark Greer [this message]
2016-12-24 16:17 ` Geoff Lansberry
2016-12-24 17:24 ` Mark Greer
2016-12-27 14:18 ` Geoff Lansberry
2017-01-03 16:33 ` Mark Greer
2017-01-03 18:35 ` Geoff Lansberry
2017-01-03 21:21 ` Mark Greer
2017-01-08 22:32 ` Geoff Lansberry
2016-12-22 23:01 ` [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock Rob Herring
2017-01-19 23:35 ` Mark Greer
2017-04-05 9:06 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161224060141.GA9069@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=aloisio.almeida@openbossa.org \
--cc=devicetree@vger.kernel.org \
--cc=geoff@kuvee.com \
--cc=jaret.cantu@timesys.com \
--cc=justin@kuvee.com \
--cc=lauro.venancio@openbossa.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).