From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
krzk@kernel.org, kgene@kernel.org, jingoohan1@gmail.com,
bhelgaas@google.com, jh80.chung@samsung.com,
alim.akhtar@samsung.com, sanath@samsung.com,
Niyas Ahmed S T <niyas.ahmed@samsung.com>
Subject: Re: [PATCH] PCI: exynos: refactor exynos pcie driver
Date: Sat, 24 Dec 2016 11:25:53 +0200 [thread overview]
Message-ID: <20161224092553.GA4858@kozik-lap> (raw)
In-Reply-To: <1482490587-13611-1-git-send-email-pankaj.dubey@samsung.com>
On Fri, Dec 23, 2016 at 04:26:27PM +0530, Pankaj Dubey wrote:
> From: Niyas Ahmed S T <niyas.ahmed@samsung.com>
>
> Currently Exynos PCIe driver is only supported for Exynos5440 SoC.
> This patch does refactoring of Exynos PCIe driver to extend support
> for other Exynos SoC.
>
> Following are the main changes done via this patch:
> 1) It adds separate structs for memory, clock resources.
> 2) It add exynos_pcie_ops struct which will allow us to support the
> differences in resources in different Exynos SoC.
>
> No functional change intended.
>
> Signed-off-by: Niyas Ahmed S T <niyas.ahmed@samsung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> This patch set is prepared on top of Krzysztof's for-next and
> PCIe driver cleanup patch [1] by Jaehoon Chung.
>
> [1]: https://lkml.org/lkml/2016/12/19/44
>
>
> drivers/pci/host/pci-exynos.c | 346 ++++++++++++++++++++++++++----------------
> 1 file changed, 217 insertions(+), 129 deletions(-)
(...)
> @@ -573,14 +660,15 @@ static int __exit exynos_pcie_remove(struct platform_device *pdev)
> {
> struct exynos_pcie *exynos_pcie = platform_get_drvdata(pdev);
>
> - clk_disable_unprepare(exynos_pcie->bus_clk);
> - clk_disable_unprepare(exynos_pcie->clk);
> + if (exynos_pcie->ops && exynos_pcie->ops->deinit_clk_resources)
> + exynos_pcie->ops->deinit_clk_resources(exynos_pcie);
>
> return 0;
> }
>
> static const struct of_device_id exynos_pcie_of_match[] = {
> - { .compatible = "samsung,exynos5440-pcie", },
> + { .compatible = "samsung,exynos5440-pcie",
> + .data = &exynos5440_pcie_ops },
A nit, please put brackets in new lines, so:
{
...
},
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
I didn't do a thorough review, though.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-12-24 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161223105411epcas1p3727f726e757ec6c6d7bff04a9af40077@epcas1p3.samsung.com>
2016-12-23 10:56 ` [PATCH] PCI: exynos: refactor exynos pcie driver Pankaj Dubey
2016-12-23 18:37 ` Jingoo Han
2016-12-27 3:27 ` Pankaj Dubey
2016-12-24 9:25 ` Krzysztof Kozlowski [this message]
2016-12-26 9:02 ` Jaehoon Chung
2016-12-26 9:06 ` Jaehoon Chung
2016-12-26 9:46 ` Alim Akhtar
2016-12-27 1:09 ` Jaehoon Chung
2016-12-27 2:12 ` Alim Akhtar
2016-12-27 2:30 ` Jaehoon Chung
2016-12-27 6:34 ` Alim Akhtar
2016-12-27 10:18 ` Jaehoon Chung
2016-12-28 3:10 ` Pankaj Dubey
2016-12-28 5:25 ` Jaehoon Chung
2016-12-26 14:43 ` Jingoo Han
2016-12-27 1:12 ` Jaehoon Chung
2016-12-27 4:21 ` Pankaj Dubey
2016-12-27 13:35 ` Bartlomiej Zolnierkiewicz
2016-12-28 3:13 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161224092553.GA4858@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=jh80.chung@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=niyas.ahmed@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=sanath@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).