From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755089AbcLXOKY (ORCPT ); Sat, 24 Dec 2016 09:10:24 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35024 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820AbcLXOKW (ORCPT ); Sat, 24 Dec 2016 09:10:22 -0500 From: Sergey Senozhatsky To: Andrew Morton Cc: Petr Mladek , Steven Rostedt , Peter Hurley , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: [PATCH 0/2] printk: always report dropped messages Date: Sat, 24 Dec 2016 23:09:00 +0900 Message-Id: <20161224140902.1962-1-sergey.senozhatsky@gmail.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Two patches: trivial clean up and console_unlock() "fix". The `printk messages dropped' report is printed as part of actual kernel message, that's why we do 'text + len, sizeof(text) - len' later in msg_print_text(). The problem here is that we may eventually skip the message, and thus lose the 'printk messages dropped' report, if `console_loglevel' check tells us to do so. Missing kernel messages in serial log together with the missing 'printk messages dropped' can be quite confusing. There are two options to address it: a) forbid suppress_message_printing() if we know that we must print `printk messages dropped' b) print `printk messages dropped' as a standalone message. Sergey Senozhatsky (2): printk: drop call_console_drivers() unused param printk: always report lost messages on serial console kernel/printk/printk.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) -- 2.11.0