From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [GIT pull] smp/hotplug: Removal of notifiers
Date: Mon, 26 Dec 2016 16:45:02 +0100 [thread overview]
Message-ID: <20161226154502.GA287@x4> (raw)
In-Reply-To: <20161226110600.GB297@x4>
On 2016.12.26 at 12:06 +0100, Markus Trippelsdorf wrote:
> On 2016.12.26 at 08:45 +0100, Markus Trippelsdorf wrote:
> > On 2016.12.25 at 14:39 +0100, Thomas Gleixner wrote:
> > > Linus,
> > >
> > > please pull the latest smp-urgent-for-linus git tree from:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus
> > >
> > > Thomas Gleixner (11):
> > > cpu/hotplug: Prevent overwriting of callbacks
> >
> > The following commit:
> >
> > commit dc280d93623927570da279e99393879dbbab39e7
> > Author: Thomas Gleixner <tglx@linutronix.de>
> > Date: Wed Dec 21 20:19:49 2016 +0100
> >
> > cpu/hotplug: Prevent overwriting of callbacks
> >
> > results in an early OOPs during boot on my AMD machine.
> > I haven't wrote down the entire backtrace, but basically things start to
> > go wrong in mce_threshold_create_device() from
> > arch/x86/kernel/cpu/mcheck/mce_amd.c.
> >
> > # CONFIG_HOTPLUG_CPU is not set
> >
> > Reverting the commit "fixes" the issue for me.
>
> CCing Sebastian and Borislav.
BUG: unable to handle kernel NULL pointer dereference at 000000000000004c
RIP: kobject_get at lib/kobject.c:594
(inlined by) kobject_add_internal at lib/kobject.c:214
? kobj_to_dev at include/linux/device.h:968 (discriminator 1)
(inlined by) get_device at drivers/base/core.c:1796 (discriminator 1)
? kobject_add at lib/kobject.c:415
? kobject_create_and_add at lib/kobject.c:753
? threshold_create_bank at arch/x86/kernel/cpu/mcheck/mce_amd.c:1212
(inlined by) mce_threshold_create_device at arch/x86/kernel/cpu/mcheck/mce_amd.c:1348
The comment in arch/x86/kernel/cpu/mcheck/mce_amd.c says:
1384 * mcheck_init_device should be inited before threshold_init_device to
1385 * initialize mce_device, otherwise a NULL ptr dereference will cause panic.
--
Markus
next prev parent reply other threads:[~2016-12-26 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 13:39 [GIT pull] smp/hotplug: Removal of notifiers Thomas Gleixner
2016-12-26 7:45 ` Markus Trippelsdorf
2016-12-26 11:06 ` Markus Trippelsdorf
2016-12-26 15:45 ` Markus Trippelsdorf [this message]
2016-12-26 17:31 ` Boris Ostrovsky
2016-12-26 18:21 ` Thomas Gleixner
2016-12-26 20:53 ` Boris Ostrovsky
2016-12-26 21:00 ` Borislav Petkov
2016-12-26 21:16 ` Thomas Gleixner
2016-12-26 21:42 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161226154502.GA287@x4 \
--to=markus@trippelsdorf.de \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).