From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: colin.king@canonical.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] skfp: hwmtm: Use proper logging macros, correct mismatches
Date: Tue, 27 Dec 2016 20:17:06 -0500 (EST) [thread overview]
Message-ID: <20161227.201706.1509861992180599997.davem@davemloft.net> (raw)
In-Reply-To: <8e5313732124084fd2084df874eed70f8f1af810.1482367105.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Wed, 21 Dec 2016 16:41:52 -0800
> Logging macros should allow format and argument validation.
> The DB_TX, DB_RX, and DB_GEN macros did not.
>
> Update the macros and uses and add no_printk validation to the
> previously compiled away #ifndef DEBUG variants.
>
> Done with coccinelle and some typing.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
prev parent reply other threads:[~2016-12-28 1:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 0:41 [PATCH] skfp: hwmtm: Use proper logging macros, correct mismatches Joe Perches
2016-12-28 1:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227.201706.1509861992180599997.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).