From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, pavel@ucw.cz, Joao.Pinto@synopsys.com,
seraphin.bonnaffe@st.com, alexandre.torgue@gmail.com,
manabian@gmail.com, niklas.cassel@axis.com, johan@kernel.org,
boon.leong.ong@intel.com, weifeng.voon@intel.com,
lars.persson@axis.com, linux-kernel@vger.kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@st.com
Subject: Re: [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and stmmac_open
Date: Tue, 27 Dec 2016 21:32:44 -0500 (EST) [thread overview]
Message-ID: <20161227.213244.1031537802471524150.davem@davemloft.net> (raw)
In-Reply-To: <20161228022306.14442-1-f.fainelli@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 27 Dec 2016 18:23:06 -0800
> There is currently a small window during which the network device registered by
> stmmac can be made visible, yet all resources, including and clock and MDIO bus
> have not had a chance to be set up, this can lead to the following error to
> occur:
...
> Fix this by making sure that register_netdev() is the last thing being done,
> which guarantees that the clock and the MDIO bus are available.
>
> Fixes: 4bfcbd7abce2 ("stmmac: Move the mdio_register/_unregister in probe/remove")
> Reported-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied and queued up for -stable, thanks Florian.
next prev parent reply other threads:[~2016-12-28 2:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 14:42 [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Kweh, Hock Leong
2016-12-27 10:48 ` Pavel Machek
2016-12-27 16:34 ` David Miller
2016-12-28 1:40 ` Kweh, Hock Leong
2016-12-28 2:23 ` [PATCH net] net: stmmac: Fix race between stmmac_drv_probe and stmmac_open Florian Fainelli
2016-12-28 2:32 ` David Miller [this message]
2016-12-28 11:56 ` [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Kishan Sandeep
2016-12-29 0:26 ` Kweh, Hock Leong
2016-12-28 5:49 ` Kweh, Hock Leong
2016-12-28 18:42 ` Florian Fainelli
2016-12-29 0:28 ` Kweh, Hock Leong
2016-12-29 0:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227.213244.1031537802471524150.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=boon.leong.ong@intel.com \
--cc=f.fainelli@gmail.com \
--cc=johan@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=pavel@ucw.cz \
--cc=peppe.cavallaro@st.com \
--cc=seraphin.bonnaffe@st.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).