From: Luis Ressel <aranea@aixah.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: mount_pseudo(), sget() and MS_KERNMOUNT
Date: Tue, 27 Dec 2016 11:20:37 +0100 [thread overview]
Message-ID: <20161227112037.015dc5ac@gentp.lnet> (raw)
Hello,
With Linux 4.8, the sget() function in fs/super.c got a new permission
check: It now returns -EPERM if
(!(flags & MS_KERNMOUNT) && !ns_capable(user_ns, CAP_SYS_ADMIN)) .
I presume the first half is intented to detect in-kernel mounts? If so,
why doesn't mount_pseudo() (in fs/libfs.c) pass the MS_KERNMOUNT flag
to sget()?
This behaviour has caused a problem for me: During graphics driver
initalization, drm_fs_inode_new() (in drivers/gpu/drm/drm_drv.c) calls
simple_pin_fs(). The MS_KERNMOUNT flag is indeed passed down the
call chain from there, but it is lost when mount_pseudo() is called, as
that function doesn't take a 'flags' argument.
Hence, the first part of the above permission check fails. (The second
part also fails under some cicumstances due to a SELinux quirk, and
therefore the initalization of my graphics driver doesn't succeed.)
Regards,
Luis Ressel
(Apologies if I'm sending this inquiry to the wrong people. I don't
know much about the kernel development workflow, so I decided to send
it to whomever get_maintainer.pl spat out, plus the author of the
sget() change in 4.8.)
next reply other threads:[~2016-12-27 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:20 Luis Ressel [this message]
2017-01-04 4:20 ` mount_pseudo(), sget() and MS_KERNMOUNT Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227112037.015dc5ac@gentp.lnet \
--to=aranea@aixah.de \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).