archive mirror
 help / color / mirror / Atom feed
* [PATCH] [media] am437x-vpfe: always assign bpp variable
@ 2016-12-27 18:02 Nicolas Iooss
  0 siblings, 0 replies; only message in thread
From: Nicolas Iooss @ 2016-12-27 18:02 UTC (permalink / raw)
  To: Lad, Prabhakar, Mauro Carvalho Chehab, Mauro Carvalho Chehab,
  Cc: linux-kernel, Nicolas Iooss, stable

In vpfe_s_fmt(), when the sensor format and the requested format were
the same, bpp was assigned to vpfe->bpp without being initialized first.

Grab the bpp value that is currently used by using __vpfe_get_format()
instead of its wrapper, vpfe_try_fmt().

This use of uninitialized variable has been found by compiling the
kernel with clang.

Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver
support for AM437X")
Signed-off-by: Nicolas Iooss <>
 drivers/media/platform/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index b33b9e35e60e..05489a401c5c 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -1576,7 +1576,7 @@ static int vpfe_s_fmt(struct file *file, void *priv,
 		return -EBUSY;
-	ret = vpfe_try_fmt(file, priv, &format);
+	ret = __vpfe_get_format(vpfe, &format, &bpp);
 	if (ret)
 		return ret;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-12-27 18:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-27 18:02 [PATCH] [media] am437x-vpfe: always assign bpp variable Nicolas Iooss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).