From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbcL1IkC (ORCPT ); Wed, 28 Dec 2016 03:40:02 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:49493 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbcL1IkB (ORCPT ); Wed, 28 Dec 2016 03:40:01 -0500 Date: Wed, 28 Dec 2016 00:39:56 -0800 From: Christoph Hellwig To: Scott Bauer Cc: Jethro Beekman , keith.busch@intel.com, sagi@grimberg.me, hch@infradead.org, Rafael.Antognolli@intel.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@fb.com, viro@zeniv.linux.org.uk, jonathan.derrick@intel.com Subject: Re: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code. Message-ID: <20161228083955.GA2811@infradead.org> References: <1482176149-2257-1-git-send-email-scott.bauer@intel.com> <1482176149-2257-5-git-send-email-scott.bauer@intel.com> <3d8b8516-aac6-c11c-dbbb-47fc01308f8c@jbeekman.nl> <20161227221221.GA2902@sbauer-Z170X-UD5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161227221221.GA2902@sbauer-Z170X-UD5> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > for OPAL. In order to determine if the controller supports opal we need to allocate > the previously mentioned structures anyway. I want to stay away from making payloads > (specifically discovery0 ) payload in the nvme driver and allow the opal core to do a > all the grunt work. In the future we'll probably have to refactor the core a bit to do > just packet generation. It looks like at least for NVMe we're going to have to do a discovery > to figure out whether we've got mutiple locking ranges per NS or just one global lr during > initialization. We might have to do discovery in the nvme driver - there also is the ATA security feature supported by various consumer drives. Jethro has been doing some work in that direction, although driven by userspace for now.