From: "Pali Rohár" <pali.rohar@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Valdis.Kletnieks@vt.edu,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Jean Delvare" <jdelvare@suse.com>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Mario Limonciello" <mario_limonciello@dell.com>,
"Alex Hung" <alex.hung@canonical.com>,
"Michał Kępień" <kernel@kempniu.pl>,
"Takashi Iwai" <tiwai@suse.de>,
linux-i2c@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines
Date: Wed, 28 Dec 2016 10:05:21 +0100 [thread overview]
Message-ID: <201612281005.22088@pali> (raw)
In-Reply-To: <CAHp75Vc4WaGu1mkMvXY3B=YSdd-Pv9YD7gJFxubDWu0Vow8=BQ@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1813 bytes --]
On Wednesday 28 December 2016 08:55:18 Andy Shevchenko wrote:
> On Wed, Dec 28, 2016 at 12:41 AM, <Valdis.Kletnieks@vt.edu> wrote:
> > On Wed, 28 Dec 2016 00:15:30 +0200, Andy Shevchenko said:
> >> On Tue, Dec 27, 2016 at 3:51 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> >
> >> > I have no idea how to do it (properly) outside of i2c-i801.c file.
> >>
> >> I doubt we need a single line of code for this. See [1] and perhaps
> >> create an EFI variable with necessary upgrade device node.
> >>
> >> > Same thing is done for Fujitsu machines, see function
> >> > i801_probe_optional_slaves() in i2c-i801.c file. So I did similar
> >> > approach for Dell machines.
> >>
> >> Perhaps, this also needs to be converted to use EFI variable.
> >>
> >> [1] https://lwn.net/Articles/693212/
> >
> > There's no guarantee that the laptops in question are booted with UEFI,
> > as Dell still supports legacy boot. So assuming the presence of EFI variables
> > is somewhat problematic.
>
>
> > In addition, it requires the user (or something in userspace) to set the UEFI
> > variable or configfs tweak, rather than Just Working Out Of The Box.
>
> I have no strong opinion, though I don't support the idea to put all
> hacks in the world to the kernel. For example, we have user space tool
> to switch USB modem from storage to actual communication device and
> that is just working out of the box.
>
> Mika, Darren, what are your opinions?
I have absolutely no idea how to you want to achieve calling that i2c_new_device() registration
without kernel patches.
So before starting discussion which option to use (EFI, kernel patch, userspace script, etc...)
please describe how would you implement such logic with different options.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-12-28 9:05 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 12:52 [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines Pali Rohár
2016-12-27 13:43 ` Wolfram Sang
2016-12-27 13:51 ` Pali Rohár
2016-12-27 22:15 ` Andy Shevchenko
2016-12-27 22:41 ` Valdis.Kletnieks
2016-12-28 7:55 ` Andy Shevchenko
2016-12-28 9:05 ` Pali Rohár [this message]
2016-12-28 14:03 ` Wolfram Sang
2016-12-29 4:37 ` Valdis.Kletnieks
2016-12-28 8:38 ` Pali Rohár
2016-12-28 14:02 ` Wolfram Sang
2017-01-04 9:45 ` Jean Delvare
2016-12-29 8:29 ` Michał Kępień
2016-12-29 9:00 ` Pali Rohár
2016-12-29 13:47 ` Michał Kępień
2016-12-29 14:17 ` Pali Rohár
2016-12-29 21:09 ` Michał Kępień
2016-12-29 21:28 ` Pali Rohár
2017-01-03 9:06 ` Benjamin Tissoires
2017-01-03 9:23 ` Pali Rohár
2017-01-03 18:38 ` Dmitry Torokhov
2017-01-03 18:50 ` Pali Rohár
2017-01-03 18:58 ` Mario.Limonciello
2017-01-03 19:48 ` Dmitry Torokhov
2017-01-03 20:05 ` Pali Rohár
2017-01-03 20:24 ` Dmitry Torokhov
2017-01-03 20:39 ` Pali Rohár
2017-01-03 20:59 ` Dmitry Torokhov
2017-01-04 8:18 ` Pali Rohár
2017-01-04 9:05 ` Benjamin Tissoires
2017-01-04 9:18 ` Pali Rohár
2017-01-04 10:13 ` Benjamin Tissoires
2017-01-04 10:21 ` Pali Rohár
2017-01-04 10:32 ` Benjamin Tissoires
2017-01-04 11:22 ` Pali Rohár
2017-01-04 12:00 ` Pali Rohár
2017-01-04 13:02 ` Benjamin Tissoires
2017-01-04 16:06 ` Pali Rohár
2017-01-04 17:39 ` Benjamin Tissoires
2017-01-04 17:46 ` Wolfram Sang
2017-01-04 17:54 ` Dmitry Torokhov
2017-01-04 21:49 ` Benjamin Tissoires
2017-01-04 21:55 ` Dmitry Torokhov
2017-01-04 21:55 ` Wolfram Sang
2017-01-04 22:00 ` Dmitry Torokhov
2017-01-04 22:03 ` Dmitry Torokhov
2017-01-05 2:20 ` [PATCH] i2c: do not enable fall back to Host Notify by default kbuild test robot
2017-01-05 2:21 ` kbuild test robot
2017-01-05 8:54 ` [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines Pali Rohár
2017-01-05 9:26 ` Benjamin Tissoires
2017-01-04 18:50 ` Jean Delvare
2017-01-04 9:53 ` Andy Shevchenko
2017-01-04 10:25 ` Benjamin Tissoires
2017-01-04 11:35 ` Pali Rohár
2017-01-04 12:33 ` Benjamin Tissoires
2017-01-03 21:29 ` Benjamin Tissoires
2017-01-04 6:36 ` Dmitry Torokhov
2017-01-04 9:13 ` Benjamin Tissoires
2017-01-04 9:25 ` Pali Rohár
2017-01-03 20:20 ` Andy Shevchenko
2017-01-04 10:18 ` Jean Delvare
2017-01-07 12:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201612281005.22088@pali \
--to=pali.rohar@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alex.hung@canonical.com \
--cc=andy.shevchenko@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=jdelvare@suse.com \
--cc=jochen@penguin-breeder.org \
--cc=kernel@kempniu.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stevenhoneyman@gmail.com \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).