From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbcL1QAf (ORCPT ); Wed, 28 Dec 2016 11:00:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:36522 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbcL1QAd (ORCPT ); Wed, 28 Dec 2016 11:00:33 -0500 Date: Wed, 28 Dec 2016 17:00:29 +0100 From: Michal Hocko To: Nikolay Borisov Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Johannes Weiner , Vlastimil Babka , Rik van Riel , LKML Subject: Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Message-ID: <20161228160029.GF11470@dhcp22.suse.cz> References: <20161228153032.10821-1-mhocko@kernel.org> <20161228153032.10821-5-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 28-12-16 17:50:31, Nikolay Borisov wrote: > > > On 28.12.2016 17:30, Michal Hocko wrote: > > From: Michal Hocko > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > from is file or anonymous but we do not know which LRU this is. It is > > useful to know whether the list is file or anonymous as well. Change > > Maybe you wanted to say whether the list is ACTIVE/INACTIVE ? You are right. I will update the wording to: " mm_vmscan_lru_isolate currently prints only whether the LRU we isolate from is file or anonymous but we do not know which LRU this is. It is useful to know whether the list is active or inactive as well as we use the same function to isolate pages for both of them. Change the tracepoint to show symbolic names of the lru rather. " Does it sound better? Thanks! -- Michal Hocko SUSE Labs