From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbcL1Wjc (ORCPT ); Wed, 28 Dec 2016 17:39:32 -0500 Received: from arcturus.aphlor.org ([188.246.204.175]:44562 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcL1Wja (ORCPT ); Wed, 28 Dec 2016 17:39:30 -0500 Date: Wed, 28 Dec 2016 16:55:14 -0500 From: Dave Jones To: Linux Kernel Mailing List Cc: Thomas Gleixner , Guenter Roeck , Linus Torvalds Subject: Re: hwmon: (coretemp) Simplify package management Message-ID: <20161228215514.cuqhp5kkgepombag@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Linux Kernel Mailing List , Thomas Gleixner , Guenter Roeck , Linus Torvalds References: <20161214005838.1F41F66102A@gitolite.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161214005838.1F41F66102A@gitolite.kernel.org> User-Agent: NeoMutt/20161126 (1.7.1) X-Spam-Flag: skipped (authorised relay user) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 12:58:38AM +0000, Linux Kernel wrote: > Web: https://git.kernel.org/torvalds/c/712668460594294d74c13f2a023398a597fbe95f > Commit: 712668460594294d74c13f2a023398a597fbe95f > Parent: 2195c31b127def509c806fe8a9d3b4092a28ce31 > Refname: refs/heads/master > Author: Thomas Gleixner > AuthorDate: Tue Nov 22 17:42:06 2016 +0000 > Committer: Guenter Roeck > CommitDate: Fri Dec 9 21:54:13 2016 -0800 > > hwmon: (coretemp) Simplify package management > > Keeping track of the per package platform devices requires an extra object, > which is held in a linked list. > > The maximum number of packages is known at init() time. So the extra object > and linked list management can be replaced by an array of platform device > pointers in which the per package devices pointers can be stored. Lookup > becomes a simple array lookup instead of a list walk. > > The mutex protecting the list can be removed as well because the array is > only accessed from cpu hotplug callbacks which are already serialized. > > Signed-off-by: Thomas Gleixner > Signed-off-by: Guenter Roeck > 1 file changed, 38 insertions(+), 82 deletions(-) > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c > index c364bfd..3ac4c03 100644 > --- a/drivers/hwmon/coretemp.c > +++ b/drivers/hwmon/coretemp.c > @@ -127,7 +122,7 @@ static ssize_t show_label(struct device *dev, > struct temp_data *tdata = pdata->core_data[attr->index]; > > if (tdata->is_pkg_data) > - return sprintf(buf, "Physical id %u\n", pdata->phys_proc_id); > + return sprintf(buf, "Package id %u\n", pdata->pkg_id); > > return sprintf(buf, "Core %u\n", tdata->cpu_core_id); > } This is breakage of a userspace ABI. Fixing up my mrtg config to cope was simple enough, but do we want to force everyone to have to do that if they upgrade their kernel ? Dave