From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbcL2DOi (ORCPT ); Wed, 28 Dec 2016 22:14:38 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:36614 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbcL2DOh (ORCPT ); Wed, 28 Dec 2016 22:14:37 -0500 Date: Wed, 28 Dec 2016 21:14:32 -0600 From: Andy Gross To: Bjorn Andersson Cc: David Brown , Mark Rutland , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , John Stultz , linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [1/5] ARM: dts: qcom: apq8064: Add missing scm clock Message-ID: <20161229031432.GA18506@hector.attlocal.net> References: <20161221114939.19973-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161221114939.19973-1-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2016 at 03:49:35AM -0800, Bjorn Andersson wrote: > As per the device tree binding the apq8064 scm node requires the core > clock to be specified, so add this. > > Cc: John Stultz > Signed-off-by: Bjorn Andersson > --- > arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index 268bd470c865..78bf155a52f3 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -303,6 +303,9 @@ > firmware { > scm { > compatible = "qcom,scm-apq8064"; > + > + clocks = <&gcc CE3_CORE_CLK>; > + clock-names = "core"; Isn't this supposed to be the DFAB clk? The RPM one? I think that's why we let the clock just fall through optionally before the recent changes that broke this. Regards, Andy