From: Michal Hocko <mhocko@kernel.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Nils Holland <nholland@tisys.org>, Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on)
Date: Thu, 29 Dec 2016 09:52:33 +0100 [thread overview]
Message-ID: <20161229085233.GD29208@dhcp22.suse.cz> (raw)
In-Reply-To: <20161229004824.GA15541@bbox>
On Thu 29-12-16 09:48:24, Minchan Kim wrote:
> On Thu, Dec 29, 2016 at 09:31:54AM +0900, Minchan Kim wrote:
[...]
> > Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
> Nit:
>
> WARNING: line over 80 characters
> #53: FILE: include/linux/memcontrol.h:689:
> +unsigned long mem_cgroup_get_zone_lru_size(struct lruvec *lruvec, enum lru_list lru,
>
> WARNING: line over 80 characters
> #147: FILE: mm/vmscan.c:248:
> +unsigned long lruvec_zone_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone_idx)
>
> WARNING: line over 80 characters
> #177: FILE: mm/vmscan.c:1446:
> + mem_cgroup_update_lru_size(lruvec, lru, zid, -nr_zone_taken[zid]);
fixed
> WARNING: line over 80 characters
> #201: FILE: mm/vmscan.c:2099:
> + inactive_zone = lruvec_zone_lru_size(lruvec, file * LRU_FILE, zid);
>
> WARNING: line over 80 characters
> #202: FILE: mm/vmscan.c:2100:
> + active_zone = lruvec_zone_lru_size(lruvec, (file * LRU_FILE) + LRU_ACTIVE, zid);
I would prefer to have those on the same line though. It will make them
easier to follow.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-12-29 8:53 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 22:57 OOM: Better, but still there on 4.9 Nils Holland
2016-12-16 7:39 ` Michal Hocko
2016-12-16 15:58 ` OOM: Better, but still there on Michal Hocko
2016-12-16 15:58 ` [PATCH 1/2] mm: consolidate GFP_NOFAIL checks in the allocator slowpath Michal Hocko
2016-12-16 15:58 ` [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically Michal Hocko
2016-12-16 17:31 ` Johannes Weiner
2016-12-16 22:12 ` Michal Hocko
2016-12-17 11:17 ` Tetsuo Handa
2016-12-18 16:37 ` Michal Hocko
2016-12-16 18:47 ` OOM: Better, but still there on Nils Holland
2016-12-17 0:02 ` Michal Hocko
2016-12-17 12:59 ` Nils Holland
2016-12-17 14:44 ` Tetsuo Handa
2016-12-17 17:11 ` Nils Holland
2016-12-17 21:06 ` Nils Holland
2016-12-18 5:14 ` Tetsuo Handa
2016-12-19 13:45 ` Michal Hocko
2016-12-20 2:08 ` Nils Holland
2016-12-21 7:36 ` Michal Hocko
2016-12-21 11:00 ` Tetsuo Handa
2016-12-21 11:16 ` Michal Hocko
2016-12-21 14:04 ` Chris Mason
2016-12-22 10:10 ` Nils Holland
2016-12-22 10:27 ` Michal Hocko
2016-12-22 10:35 ` Nils Holland
2016-12-22 10:46 ` Tetsuo Handa
2016-12-22 19:17 ` Michal Hocko
2016-12-22 21:46 ` Nils Holland
2016-12-23 10:51 ` Michal Hocko
2016-12-23 12:18 ` Nils Holland
2016-12-23 12:57 ` Michal Hocko
2016-12-23 14:47 ` [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on) Michal Hocko
2016-12-23 22:26 ` Nils Holland
2016-12-26 12:48 ` Michal Hocko
2016-12-26 18:57 ` Nils Holland
2016-12-27 8:08 ` Michal Hocko
2016-12-27 11:23 ` Nils Holland
2016-12-27 11:27 ` Michal Hocko
2016-12-27 15:55 ` Michal Hocko
2016-12-27 16:28 ` [PATCH] mm, vmscan: consider eligible zones in get_scan_count kbuild test robot
2016-12-28 8:51 ` Michal Hocko
2016-12-27 19:33 ` [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on) Nils Holland
2016-12-28 8:57 ` Michal Hocko
2016-12-29 1:20 ` Minchan Kim
2016-12-29 9:04 ` Michal Hocko
2016-12-30 2:05 ` Minchan Kim
2016-12-30 10:40 ` Michal Hocko
2016-12-29 0:31 ` Minchan Kim
2016-12-29 0:48 ` Minchan Kim
2016-12-29 8:52 ` Michal Hocko [this message]
2016-12-30 10:19 ` Mel Gorman
2016-12-30 11:05 ` Michal Hocko
2016-12-30 12:43 ` Mel Gorman
2016-12-25 22:25 ` [lkp-developer] [mm, memcg] d18e2b2aca: WARNING:at_mm/memcontrol.c:#mem_cgroup_update_lru_size kernel test robot
2016-12-26 12:26 ` Michal Hocko
2016-12-26 12:50 ` Michal Hocko
2016-12-18 0:28 ` OOM: Better, but still there on Xin Zhou
2016-12-16 18:15 ` OOM: Better, but still there on 4.9 Chris Mason
2016-12-16 22:14 ` Michal Hocko
2016-12-16 22:47 ` Chris Mason
2016-12-16 23:31 ` Michal Hocko
2016-12-16 19:50 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229085233.GD29208@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=hannes@cmpxchg.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=nholland@tisys.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).