From: David Miller <davem@davemloft.net>
To: thomas.preisner+linux@fau.de
Cc: dave@thedillows.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de,
milan.stephan+linux@fau.de, sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix incorrect return values
Date: Fri, 30 Dec 2016 15:27:09 -0500 (EST) [thread overview]
Message-ID: <20161230.152709.841426532104836350.davem@davemloft.net> (raw)
In-Reply-To: <1483065474-11512-2-git-send-email-thomas.preisner+linux@fau.de>
From: Thomas Preisner <thomas.preisner+linux@fau.de>
Date: Fri, 30 Dec 2016 03:37:53 +0100
> In a few cases the err-variable is not set to a negative error code if a
> function call in typhoon_init_one() fails and thus 0 is returned
> instead.
> It may be better to set err to the appropriate negative error
> code before returning.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841
>
> Reported-by: Pan Bian <bianpan2016@163.com>
> Signed-off-by: Thomas Preisner <thomas.preisner+linux@fau.de>
> Signed-off-by: Milan Stephan <milan.stephan+linux@fau.de>
Applied to net-next.
next prev parent reply other threads:[~2016-12-30 20:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 23:00 [PATCH] drivers: net: ethernet: 3com: fix return value Thomas Preisner
2016-12-24 1:05 ` David Dillow
2016-12-24 12:02 ` Thomas Preisner
2016-12-24 12:02 ` [PATCH v2 1/2] " Thomas Preisner
2016-12-24 19:06 ` Sergei Shtylyov
2016-12-25 0:30 ` Thomas Preisner
2016-12-25 0:30 ` [PATCH v3 " Thomas Preisner
2016-12-25 0:56 ` David Miller
2016-12-25 0:30 ` [PATCH v3 2/2] " Thomas Preisner
2016-12-25 10:07 ` Sergei Shtylyov
2016-12-27 21:17 ` David Dillow
2016-12-30 2:37 ` Thomas Preisner
2016-12-30 2:37 ` [PATCH v4 1/2] net: 3com: typhoon: typhoon_init_one: fix incorrect return values Thomas Preisner
2016-12-30 20:27 ` David Miller [this message]
2016-12-30 2:37 ` [PATCH v4 2/2] net: 3com: typhoon: typhoon_init_one: make return values more specific Thomas Preisner
2016-12-30 20:27 ` David Miller
2016-12-27 21:15 ` Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value David Dillow
2016-12-24 12:02 ` [PATCH v2 2/2] " Thomas Preisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161230.152709.841426532104836350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave@thedillows.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=milan.stephan+linux@fau.de \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.preisner+linux@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).