From: David Miller <davem@davemloft.net>
To: niklas.cassel@axis.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, niklass@axis.com, eric@engestrom.ch,
gabriel.fernandez@linaro.org, manabian@gmail.com,
vpalatin@chromium.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: remove unused duplicate property snps,axi_all
Date: Sun, 01 Jan 2017 11:55:46 -0500 (EST) [thread overview]
Message-ID: <20170101.115546.156775699826522389.davem@davemloft.net> (raw)
In-Reply-To: <1483102609-21926-1-git-send-email-niklass@axis.com>
From: Niklas Cassel <niklas.cassel@axis.com>
Date: Fri, 30 Dec 2016 13:56:46 +0100
> From: Niklas Cassel <niklas.cassel@axis.com>
>
> For core revision 3.x Address-Aligned Beats is available in two registers.
> The DT property snps,aal was created for AAL in the DMA bus register,
> which is a read/write bit.
> The DT property snps,axi_all was created for AXI_AAL in the AXI bus mode
> register, which is a read only bit that reflects the value of AAL in the
> DMA bus register.
>
> Since the value of snps,axi_all is never used in the driver,
> and since the property was created for a bit that is read only,
> it should be safe to remove the property.
>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2017-01-01 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 12:56 [PATCH] net: stmmac: remove unused duplicate property snps,axi_all Niklas Cassel
2017-01-01 16:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170101.115546.156775699826522389.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@engestrom.ch \
--cc=gabriel.fernandez@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).