From: David Miller <davem@davemloft.net>
To: ian.kumlien@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Update pptp handling to avoid null pointer deref.
Date: Sun, 01 Jan 2017 23:07:53 -0500 (EST) [thread overview]
Message-ID: <20170101.230753.2076894379858224939.davem@davemloft.net> (raw)
In-Reply-To: <20170101231936.5905-1-ian.kumlien@gmail.com>
From: Ian Kumlien <ian.kumlien@gmail.com>
Date: Mon, 2 Jan 2017 00:19:36 +0100
> __skb_flow_dissect can be called with a skb or a data packet, either
> can be NULL. All calls seems to have been moved to __skb_header_pointer
> except the pptp handling which is still calling skb_header_pointer.
>
> skb_header_pointer will use skb->data and thus:
...
> ---
>
> Signed-off-by: Ian Kumlien <ian.kumlien@gmail.com>
You need to fix some parts of your submission.
Do not put the signoff after the "---", git will remove all text
after that "---" from the commit message.
You must include a proper "Fixes: " tag which indicates which change
introduced this regression. This is critical for analyzing your fix
and also for figuring out which -stable releases your fix should be
backported to.
In this case the guilty commit is ab10dccb1160 ("rps: Inspect PPTP
encapsulated by GRE to get flow hash")
next prev parent reply other threads:[~2017-01-02 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 23:19 [PATCH] Update pptp handling to avoid null pointer deref Ian Kumlien
2017-01-02 4:07 ` David Miller [this message]
2017-01-02 8:05 ` Ian Kumlien
2017-01-02 8:16 ` [PATCH] Update pptp handling to avoid null pointer deref. v2 Ian Kumlien
2017-01-02 8:18 ` Ian Kumlien
2017-01-02 17:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170101.230753.2076894379858224939.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.kumlien@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).