From: Leon Romanovsky <leon@kernel.org>
To: Kenneth Lee <liguozhu@hisilicon.com>
Cc: dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, robin.murphy@arm.com, jroedel@suse.de,
egtvedt@samfundet.no, vgupta@synopsys.com,
dave.hansen@linux.intel.com, lstoakes@gmail.com, krzk@kernel.org,
sebott@linux.vnet.ibm.com, markb@mellanox.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] IB/umem: Release pid in error and ODP flow
Date: Sun, 1 Jan 2017 08:47:12 +0200 [thread overview]
Message-ID: <20170101064712.GQ26885@mtr-leonro.local> (raw)
In-Reply-To: <1483093109-188428-1-git-send-email-liguozhu@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 1985 bytes --]
On Fri, Dec 30, 2016 at 06:18:29PM +0800, Kenneth Lee wrote:
> There are two bugfixes in this patch:
>
> Fixes: 87773dd56d54 ("IB: ib_umem_release() should decrement mm->pinned_vm from ib_umem_get")
> This patch introduce the get_task_pid but not put it back on all error
> path
>
> Fixes: 8ada2c1c0c1d ("IB/core: Add support for on demand paging regions")
> This patch introduce a ODP flow without release pid before enter it
>
>
> Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>
> Reviewed-by: Haggai Eran <haggaie@mellanox.com>
> ---
> Change from v1 to v2:
> Correcting the patch title and description
> Change from v2 to v3:
> Update the title and add "Fixes" fields in the description
OK,
I see that you still didn't read Documentation/SubmittingPatches. You
must read that document before you are sending patches.
But I'll stop here, the code is correct (it fixes bugs) and commit message
more usefull than before.
>
> drivers/infiniband/core/umem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
> index 1e62a5f..4609b92 100644
> --- a/drivers/infiniband/core/umem.c
> +++ b/drivers/infiniband/core/umem.c
> @@ -134,6 +134,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
> IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND));
>
> if (access & IB_ACCESS_ON_DEMAND) {
> + put_pid(umem->pid);
> ret = ib_umem_odp_get(context, umem);
> if (ret) {
> kfree(umem);
> @@ -149,6 +150,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
>
> page_list = (struct page **) __get_free_page(GFP_KERNEL);
> if (!page_list) {
> + put_pid(umem->pid);
> kfree(umem);
> return ERR_PTR(-ENOMEM);
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-01 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 10:18 [PATCH v3] IB/umem: Release pid in error and ODP flow Kenneth Lee
2017-01-01 6:47 ` Leon Romanovsky [this message]
2017-01-03 2:11 ` Kenneth Lee
2017-01-03 2:32 ` Kenneth Lee
2017-01-03 10:12 ` Leon Romanovsky
2017-01-04 7:07 ` Kenneth Lee
2017-01-04 7:08 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170101064712.GQ26885@mtr-leonro.local \
--to=leon@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dledford@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=hal.rosenstock@gmail.com \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=markb@mellanox.com \
--cc=robin.murphy@arm.com \
--cc=sean.hefty@intel.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).