Hi Luis, [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.10-rc1 next-20161224] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luis-Oliveira/i2c-designware-Cleaning-and-comment-style-fixes/20161229-010120 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: i386-randconfig-c0-01010626 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-designware-slave.c: In function 'i2c_dw_irq_handler_slave': >> drivers/i2c/busses/i2c-designware-slave.c:293:3: error: implicit declaration of function 'i2c_slave_event' [-Werror=implicit-function-declaration] i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val); ^ >> drivers/i2c/busses/i2c-designware-slave.c:293:31: error: 'I2C_SLAVE_WRITE_REQUESTED' undeclared (first use in this function) i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val); ^ drivers/i2c/busses/i2c-designware-slave.c:293:31: note: each undeclared identifier is reported only once for each function it appears in In file included from include/linux/err.h:4:0, from drivers/i2c/busses/i2c-designware-slave.c:23: >> drivers/i2c/busses/i2c-designware-slave.c:300:6: error: 'I2C_SLAVE_WRITE_RECEIVED' undeclared (first use in this function) I2C_SLAVE_WRITE_RECEIVED, &val)) { ^ include/linux/compiler.h:149:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ drivers/i2c/busses/i2c-designware-slave.c:299:5: note: in expansion of macro 'if' if (!i2c_slave_event(dev->slave, ^ >> drivers/i2c/busses/i2c-designware-slave.c:312:7: error: 'I2C_SLAVE_READ_REQUESTED' undeclared (first use in this function) I2C_SLAVE_READ_REQUESTED, &val)) ^ include/linux/compiler.h:149:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ drivers/i2c/busses/i2c-designware-slave.c:311:4: note: in expansion of macro 'if' if (!i2c_slave_event(dev->slave, ^ >> drivers/i2c/busses/i2c-designware-slave.c:318:36: error: 'I2C_SLAVE_READ_PROCESSED' undeclared (first use in this function) if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED, ^ include/linux/compiler.h:149:30: note: in definition of macro '__trace_if' if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ ^ drivers/i2c/busses/i2c-designware-slave.c:318:3: note: in expansion of macro 'if' if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED, ^ >> drivers/i2c/busses/i2c-designware-slave.c:322:31: error: 'I2C_SLAVE_STOP' undeclared (first use in this function) i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val); ^ drivers/i2c/busses/i2c-designware-slave.c: At top level: >> drivers/i2c/busses/i2c-designware-slave.c:359:2: error: unknown field 'reg_slave' specified in initializer .reg_slave = i2c_dw_reg_slave, ^ drivers/i2c/busses/i2c-designware-slave.c:359:2: warning: excess elements in struct initializer drivers/i2c/busses/i2c-designware-slave.c:359:2: warning: (near initialization for 'i2c_dw_algo') >> drivers/i2c/busses/i2c-designware-slave.c:360:2: error: unknown field 'unreg_slave' specified in initializer .unreg_slave = i2c_dw_unreg_slave, ^ drivers/i2c/busses/i2c-designware-slave.c:360:2: warning: excess elements in struct initializer drivers/i2c/busses/i2c-designware-slave.c:360:2: warning: (near initialization for 'i2c_dw_algo') cc1: some warnings being treated as errors vim +/i2c_slave_event +293 drivers/i2c/busses/i2c-designware-slave.c 287 dw_readl(dev, DW_IC_CLR_START_DET); 288 if (stat & DW_IC_INTR_ACTIVITY) 289 dw_readl(dev, DW_IC_CLR_ACTIVITY); 290 if (stat & DW_IC_INTR_RX_OVER) 291 dw_readl(dev, DW_IC_CLR_RX_OVER); 292 if ((stat & DW_IC_INTR_RX_FULL) && (stat & DW_IC_INTR_STOP_DET)) > 293 i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_REQUESTED, &val); 294 295 if (slave_activity) { 296 if (stat & DW_IC_INTR_RD_REQ) { 297 if (stat & DW_IC_INTR_RX_FULL) { 298 val = dw_readl(dev, DW_IC_DATA_CMD); 299 if (!i2c_slave_event(dev->slave, > 300 I2C_SLAVE_WRITE_RECEIVED, &val)) { 301 dev_dbg(dev->dev, "Byte %X acked!", 302 val); 303 } 304 dw_readl(dev, DW_IC_CLR_RD_REQ); 305 stat = i2c_dw_read_clear_intrbits_slave(dev); 306 } else { 307 dw_readl(dev, DW_IC_CLR_RD_REQ); 308 dw_readl(dev, DW_IC_CLR_RX_UNDER); 309 stat = i2c_dw_read_clear_intrbits_slave(dev); 310 } 311 if (!i2c_slave_event(dev->slave, > 312 I2C_SLAVE_READ_REQUESTED, &val)) 313 dw_writel(dev, val, DW_IC_DATA_CMD); 314 } 315 } 316 317 if (stat & DW_IC_INTR_RX_DONE) { > 318 if (!i2c_slave_event(dev->slave, I2C_SLAVE_READ_PROCESSED, 319 &val)) 320 dw_readl(dev, DW_IC_CLR_RX_DONE); 321 > 322 i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val); 323 stat = i2c_dw_read_clear_intrbits_slave(dev); 324 return true; 325 } 326 327 if (stat & DW_IC_INTR_RX_FULL) { 328 val = dw_readl(dev, DW_IC_DATA_CMD); 329 if (!i2c_slave_event(dev->slave, I2C_SLAVE_WRITE_RECEIVED, 330 &val)) 331 dev_dbg(dev->dev, "Byte %X acked!", val); 332 } else { 333 i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val); 334 stat = i2c_dw_read_clear_intrbits_slave(dev); 335 } 336 337 if (stat & DW_IC_INTR_TX_OVER) 338 dw_readl(dev, DW_IC_CLR_TX_OVER); 339 340 return 1; 341 } 342 343 static irqreturn_t i2c_dw_isr_slave(int this_irq, void *dev_id) 344 { 345 struct dw_i2c_dev *dev = dev_id; 346 int ret; 347 348 i2c_dw_read_clear_intrbits_slave(dev); 349 ret = i2c_dw_irq_handler_slave(dev); 350 351 if (ret > 0) 352 complete(&dev->cmd_complete); 353 354 return IRQ_RETVAL(ret); 355 } 356 357 static struct i2c_algorithm i2c_dw_algo = { 358 .functionality = i2c_dw_func, > 359 .reg_slave = i2c_dw_reg_slave, > 360 .unreg_slave = i2c_dw_unreg_slave, 361 }; 362 363 void i2c_dw_disable_slave(struct dw_i2c_dev *dev) --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation