From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753772AbdABFuh (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Jan 2017 00:50:37 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:50771 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750803AbdABFug (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Jan 2017 00:50:36 -0500
Date: Sun, 1 Jan 2017 21:50:33 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
        Jessica Yu <jeyu@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] taint/module: Fix problems when out-of-kernel driver
 defines true or false
Message-ID: <20170102055032.GA6801@infradead.org>
References: <20170102022525.29661-1-Larry.Finger@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170102022525.29661-1-Larry.Finger@lwfinger.net>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jan 01, 2017 at 08:25:25PM -0600, Larry Finger wrote:
> Commit 7fd8329ba502 ("taint/module: Clean up global and module taint
> flags handling") used the key words true and false as character members
> of a new struct. These names cause problems when out-of-kernel modules
> such as VirtualBox include their own definitions of true and false.

Whuch they should not define, so fix them, just like you;d fix them for
everything else that would conflict with something in kernel headers.