linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Tony Lindgren <tony@atomide.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Aaro Koskinen <aaro.koskinen@iki.fi>, Nishanth Menon <nm@ti.com>,
	Sebastian Reichel <sre@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	joerg Reisenweber <joerg@openmoko.org>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Nokia N900 sound driver and ECI GPIOs
Date: Mon, 2 Jan 2017 09:44:32 +0100	[thread overview]
Message-ID: <20170102084432.GA6728@pali> (raw)
In-Reply-To: <6462f543-0422-8146-a196-f4e07c3ebb6f@ti.com>

On Monday 02 January 2017 10:23:23 Peter Ujfalusi wrote:
> Hi,
> 
> On 01/01/2017 09:54 PM, Pali Rohár wrote:
> > Hi!
> > 
> > I'm looking at original Maemo N900 2.6.28 sound driver and GPIOs which
> > controls A/V jack detection.
> > 
> > For reference source code of that driver can be found e.g. at alsa-devel
> > ML [1] [2] or in my linux-n900 git tree, branch v2.6.28-nokia [3].
> > 
> > In that sound/soc/omap/rx51.c code is function rx51_set_eci_switches()
> > which configures 2 gpios: RX51_ECI_SWITCH_1_GPIO = gpio 178 and
> > RX51_ECI_SWITCH_2_GPIO = gpio 182 based on "eci mode" input parameter.
> > 
> > But in mainline kernel code [4] [5] there is no information about gpio 178
> > (as RX51_ECI_SWITCH_1_GPIO) and gpio 182 is called as just "eci-switch".
> > More interesting part is that "eci-switch" gpio is not used in whole
> > mainline code. It is just referenced in Nokia N900 DTS [4]. Looks like
> > sound driver in mainline kernel is incomplete.
> > 
> > Jarkko, you are listed as original author of that driver. Do you (or
> > anybody else) remember what that rx51_set_eci_switches() function is
> > doing? And what gpio 178 controls? I was even not able to find gpio 178
> > in RX-51 Schematics [6].
> 
> GPIO_182 is to select where to route the MIC line from the jack for the
> ECI core to handle (when the TVOUT is disabled).

Yes, already figured out from schematic.

> I have no idea what the
> gpio_178 should have been used for. It might be only needed for early
> protos but not in production devices?

I do not know, reason why I'm asking.

> > And do you know something about Nokia ECI headsets supports for Nokia
> > N900. Looks like there is already some kernel code but support for ECI
> > bus or multibuttons headset is missing.
> 
> Not sure if n900 had full support for ECI, afaik n9 did supported it.
> The ECI input driver was sent upstream, but can not recall the reason
> why it is not in mainline:
> 
> https://patchwork.kernel.org/patch/450811/

That driver is just kernel input glue for some unknown (audio?) chip.
Nothing useful for Nokia N900. To work it is needed another driver which
fill data to that input one.

> > 
> > [1] - http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022033.html
> > 
> > [2] - http://mailman.alsa-project.org/pipermail/alsa-devel/2009-October/022039.html
> > 
> > [3] - https://github.com/pali/linux-n900/blob/v2.6.28-nokia/sound/soc/omap/rx51.c
> > 
> > [4] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/omap3-n900.dts#n128
> > 
> > [5] - https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/rx51.c
> > 
> > [6] - https://wiki.maemo.org/N900_Hardware_Schematic
> > 
> 

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2017-01-02  8:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-01 19:54 Nokia N900 sound driver and ECI GPIOs Pali Rohár
2017-01-01 22:36 ` Pavel Machek
2017-01-02  8:34   ` Peter Ujfalusi
2017-01-02  8:51     ` Pali Rohár
2017-01-02 12:53       ` Peter Ujfalusi
2017-01-02 12:58         ` Pali Rohár
2017-01-02 14:36           ` Peter Ujfalusi
2017-01-02 15:51             ` joerg Reisenweber
2017-01-02 17:02             ` Pali Rohár
2017-01-02 15:45       ` joerg Reisenweber
2017-01-02  9:01   ` Jarkko Nikula
2017-01-02  9:29     ` Pali Rohár
2017-01-02  9:33     ` Pavel Machek
2017-01-02 16:07     ` joerg Reisenweber
2017-01-02  8:23 ` Peter Ujfalusi
2017-01-02  8:44   ` Pali Rohár [this message]
2017-01-02 18:49     ` Aaro Koskinen
2017-01-02 20:01       ` Pali Rohár
2017-01-02 21:05         ` joerg Reisenweber
2017-01-04 22:27           ` Aaro Koskinen
2017-01-04 22:41             ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102084432.GA6728@pali \
    --to=pali.rohar@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=edubezval@gmail.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=joerg@openmoko.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pavel@ucw.cz \
    --cc=peter.ujfalusi@ti.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).