From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755484AbdABKvr (ORCPT ); Mon, 2 Jan 2017 05:51:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:38239 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755410AbdABKvq (ORCPT ); Mon, 2 Jan 2017 05:51:46 -0500 Date: Mon, 2 Jan 2017 11:51:43 +0100 From: Petr Mladek To: Larry Finger Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Jessica Yu , Rusty Russell Subject: Re: [PATCH] taint/module: Fix problems when out-of-kernel driver defines true or false Message-ID: <20170102105142.GE14894@pathway.suse.cz> References: <20170102022525.29661-1-Larry.Finger@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170102022525.29661-1-Larry.Finger@lwfinger.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2017-01-01 20:25:25, Larry Finger wrote: > Commit 7fd8329ba502 ("taint/module: Clean up global and module taint > flags handling") used the key words true and false as character members > of a new struct. These names cause problems when out-of-kernel modules > such as VirtualBox include their own definitions of true and false. > > Fixes: 7fd8329ba502 ("taint/module: Clean up global and module taint flags handling") > Signed-off-by: Larry Finger > Cc: Petr Mladek > Cc: Jessica Yu > Cc: Rusty Russell I like this variant a bit more than the tainted/untainted one. Reviewed-by: Petr Mladek Best Regards, Petr