From: Michal Hocko <mhocko@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
linux-ext4@vger.kernel.org,
Anatoly Stepanov <astepanov@cloudlinux.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH] mm: introduce kv[mz]alloc helpers
Date: Mon, 2 Jan 2017 17:02:50 +0100 [thread overview]
Message-ID: <20170102160249.GA11635@dhcp22.suse.cz> (raw)
In-Reply-To: <1483372522.1955.20.camel@perches.com>
On Mon 02-01-17 07:55:22, Joe Perches wrote:
> On Mon, 2017-01-02 at 14:37 +0100, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@suse.com>
> >
> > Using kmalloc with the vmalloc fallback for larger allocations is a
> > common pattern in the kernel code. Yet we do not have any common helper
> > for that and so users have invented their own helpers. Some of them are
> > really creative when doing so. Let's just add kv[mz]alloc and make sure
> > it is implemented properly. This implementation makes sure to not make
> > a large memory pressure for > PAGE_SZE requests (__GFP_NORETRY) and also
> > to not warn about allocation failures. This also rules out the OOM
> > killer as the vmalloc is a more approapriate fallback than a disruptive
> > user visible action.
> >
> > This patch also changes some existing users and removes helpers which
> > are specific for them. In some cases this is not possible (e.g.
> > ext4_kvmalloc, libcfs_kvzalloc, __aa_kvmalloc) because those seems to be
> > broken and require GFP_NO{FS,IO} context which is not vmalloc compatible
> > in general (note that the page table allocation is GFP_KERNEL). Those
> > need to be fixed separately.
> >
> > apparmor has already claimed kv[mz]alloc so remove those and use
> > __aa_kvmalloc instead to prevent from the naming clashes.
>
> I have no real objection but perhaps this would
> be better done as 3 or more patches
>
> o rename apparmor uses
> o introduce generic
> o conversions to generic
Whatever maintainers of the respective code prefer. I usually prefer to
have newly introduced functions along with their users so that it is
clear how they are used. The patch doesn't seem to be too large
either...
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-01-02 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 13:37 [PATCH] mm: introduce kv[mz]alloc helpers Michal Hocko
2017-01-02 15:55 ` Joe Perches
2017-01-02 16:02 ` Michal Hocko [this message]
2017-01-03 10:23 ` Vlastimil Babka
2017-01-03 10:33 ` Michal Hocko
2017-01-04 14:20 ` Michal Hocko
2017-01-06 14:36 ` Vlastimil Babka
2017-01-06 15:10 ` Michal Hocko
2017-01-04 18:12 ` [PATCH] mm: support __GFP_REPEAT in kvmalloc_node Michal Hocko
2017-01-06 12:09 ` Vlastimil Babka
2017-01-06 12:31 ` Michal Hocko
2017-01-09 8:50 ` Michal Hocko
2017-01-06 13:29 ` [PATCH] mm: introduce kv[mz]alloc helpers Vlastimil Babka
2017-01-06 13:34 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102160249.GA11635@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=astepanov@cloudlinux.com \
--cc=hannes@cmpxchg.org \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).