From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756372AbdABQVT (ORCPT ); Mon, 2 Jan 2017 11:21:19 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35402 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755987AbdABQVP (ORCPT ); Mon, 2 Jan 2017 11:21:15 -0500 Date: Mon, 2 Jan 2017 17:21:03 +0100 From: Gary Bisson To: Tony Lindgren Cc: Linus Walleij , Haojian Zhuang , Masahiro Yamada , Grygorii Strashko , Nishanth Menon , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [3/5] pinctrl: core: Add generic pinctrl functions for managing groups Message-ID: <20170102162103.xp5ekyyc6dwpeh4j@t450s.lan> References: <20161227172003.6517-4-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161227172003.6517-4-tony@atomide.com> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, On Tue, Dec 27, 2016 at 09:20:01AM -0800, Tony Lindgren wrote: > We can add generic helpers for function handling for cases where the pin > controller driver does not need to use static arrays. > > Signed-off-by: Tony Lindgren Shouldn't the patch title be: pinctrl: core: Add generic pinmux functions for managing functions It looks like a copy/paste issue since both patches have the same title: 824bef17d16c pinctrl: core: Add generic pinctrl functions for managing groups d70a0fb14682 pinctrl: core: Add generic pinctrl functions for managing groups That's actually my only remark, I had another comment about freeing the trees but it is actually done in the unregister so everything is good. Regards, Gary