From: Tony Lindgren <tony@atomide.com>
To: Gary Bisson <gary.bisson@boundarydevices.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Nishanth Menon <nm@ti.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [3/5] pinctrl: core: Add generic pinctrl functions for managing groups
Date: Mon, 2 Jan 2017 09:08:50 -0800 [thread overview]
Message-ID: <20170102170850.GC9325@atomide.com> (raw)
In-Reply-To: <20170102162103.xp5ekyyc6dwpeh4j@t450s.lan>
* Gary Bisson <gary.bisson@boundarydevices.com> [170102 08:21]:
> Hi Tony,
>
> On Tue, Dec 27, 2016 at 09:20:01AM -0800, Tony Lindgren wrote:
> > We can add generic helpers for function handling for cases where the pin
> > controller driver does not need to use static arrays.
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Shouldn't the patch title be:
> pinctrl: core: Add generic pinmux functions for managing functions
>
> It looks like a copy/paste issue since both patches have the same title:
> 824bef17d16c pinctrl: core: Add generic pinctrl functions for managing
> groups
> d70a0fb14682 pinctrl: core: Add generic pinctrl functions for managing
> groups
Oops, oh well.. At least the description is correct.
> That's actually my only remark, I had another comment about freeing the
> trees but it is actually done in the unregister so everything is good.
OK cool.
Tony
next prev parent reply other threads:[~2017-01-02 17:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 17:19 [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Tony Lindgren
2016-12-27 17:19 ` [PATCH 1/5] pinctrl: core: Use delayed work for hogs Tony Lindgren
2016-12-30 13:46 ` Linus Walleij
2017-01-10 14:08 ` Geert Uytterhoeven
2017-01-10 15:30 ` Tony Lindgren
2017-01-10 19:19 ` Tony Lindgren
2017-01-11 15:33 ` Linus Walleij
2017-01-11 16:28 ` Tony Lindgren
2017-01-11 18:31 ` Tony Lindgren
2016-12-27 17:20 ` [PATCH 2/5] pinctrl: core: Add generic pinctrl functions for managing groups Tony Lindgren
2016-12-30 14:12 ` Linus Walleij
2016-12-30 15:57 ` Tony Lindgren
2016-12-27 17:20 ` [PATCH 3/5] " Tony Lindgren
2016-12-30 14:09 ` Linus Walleij
2016-12-30 14:28 ` Linus Walleij
2017-01-02 16:21 ` [3/5] " Gary Bisson
2017-01-02 17:08 ` Tony Lindgren [this message]
2016-12-27 17:20 ` [PATCH 4/5] pinctrl: single: Use generic pinctrl helpers " Tony Lindgren
2016-12-30 14:32 ` Linus Walleij
2016-12-27 17:20 ` [PATCH 5/5] pinctrl: single: Use generic pinmux helpers for managing functions Tony Lindgren
2016-12-30 14:35 ` Linus Walleij
2016-12-30 14:39 ` [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Linus Walleij
2016-12-30 15:43 ` Gary Bisson
2016-12-30 15:59 ` Tony Lindgren
2017-01-02 16:14 ` Gary Bisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102170850.GC9325@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=gary.bisson@boundarydevices.com \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).