From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757306AbdACBnH (ORCPT ); Mon, 2 Jan 2017 20:43:07 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:15433 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755933AbdACBnF (ORCPT ); Mon, 2 Jan 2017 20:43:05 -0500 Date: Tue, 3 Jan 2017 10:11:57 +0800 From: Kenneth Lee To: Leon Romanovsky CC: , , , , , , , , , , , , , Subject: Re: [PATCH v3] IB/umem: Release pid in error and ODP flow Message-ID: <20170103021157.GA194204@Turing-Arch-b> References: <1483093109-188428-1-git-send-email-liguozhu@hisilicon.com> <20170101064712.GQ26885@mtr-leonro.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170101064712.GQ26885@mtr-leonro.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.586B00E7.009D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 4c583579ef79d80baea1e3a4d3906bb4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, I did read the doc, but maybe I mis-understant some points. Could you please point it out? On Sun, Jan 01, 2017 at 08:47:12AM +0200, Leon Romanovsky wrote: > Date: Sun, 1 Jan 2017 08:47:12 +0200 > From: Leon Romanovsky > To: Kenneth Lee > CC: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, > robin.murphy@arm.com, jroedel@suse.de, egtvedt@samfundet.no, > vgupta@synopsys.com, dave.hansen@linux.intel.com, lstoakes@gmail.com, > krzk@kernel.org, sebott@linux.vnet.ibm.com, markb@mellanox.com, > linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org > Subject: Re: [PATCH v3] IB/umem: Release pid in error and ODP flow > User-Agent: Mutt/1.7.2 (2016-11-26) > Message-ID: <20170101064712.GQ26885@mtr-leonro.local> > > On Fri, Dec 30, 2016 at 06:18:29PM +0800, Kenneth Lee wrote: > > There are two bugfixes in this patch: > > > > Fixes: 87773dd56d54 ("IB: ib_umem_release() should decrement mm->pinned_vm from ib_umem_get") > > This patch introduce the get_task_pid but not put it back on all error > > path > > > > Fixes: 8ada2c1c0c1d ("IB/core: Add support for on demand paging regions") > > This patch introduce a ODP flow without release pid before enter it > > > > > > Signed-off-by: Kenneth Lee > > Reviewed-by: Haggai Eran > > --- > > Change from v1 to v2: > > Correcting the patch title and description > > Change from v2 to v3: > > Update the title and add "Fixes" fields in the description > > OK, > > I see that you still didn't read Documentation/SubmittingPatches. You > must read that document before you are sending patches. > > But I'll stop here, the code is correct (it fixes bugs) and commit message > more usefull than before. > > > > > > drivers/infiniband/core/umem.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c > > index 1e62a5f..4609b92 100644 > > --- a/drivers/infiniband/core/umem.c > > +++ b/drivers/infiniband/core/umem.c > > @@ -134,6 +134,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr, > > IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND)); > > > > if (access & IB_ACCESS_ON_DEMAND) { > > + put_pid(umem->pid); > > ret = ib_umem_odp_get(context, umem); > > if (ret) { > > kfree(umem); > > @@ -149,6 +150,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr, > > > > page_list = (struct page **) __get_free_page(GFP_KERNEL); > > if (!page_list) { > > + put_pid(umem->pid); > > kfree(umem); > > return ERR_PTR(-ENOMEM); > > } > > -- > > 1.9.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -Kenneth(Hisilicon)