From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758632AbdACMbd (ORCPT ); Tue, 3 Jan 2017 07:31:33 -0500 Received: from foss.arm.com ([217.140.101.70]:55164 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758572AbdACMbZ (ORCPT ); Tue, 3 Jan 2017 07:31:25 -0500 Date: Tue, 3 Jan 2017 12:31:20 +0000 From: Catalin Marinas To: zhongjiang Cc: will.deacon@arm.com, rrichter@cavium.com, mark.rutland@arm.com, arnd@arndb.de, ard.biesheuvel@linaro.org, robh+dt@kernel.org, dwoods@ezchip.com, jeremy.linton@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH 1/2] arm64: change from CONT_PMD_SHIFT to CONT_PTE_SHIFT Message-ID: <20170103123120.GA1244@e104818-lin.cambridge.arm.com> References: <1481725151-20549-1-git-send-email-zhongjiang@huawei.com> <1481725151-20549-2-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481725151-20549-2-git-send-email-zhongjiang@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2016 at 10:19:10PM +0800, zhongjiang wrote: > From: zhong jiang > > I think that CONT_PTE_SHIFT is more reasonable even if they are some > value. and the patch is not any functional change. > > Signed-off-by: zhong jiang > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 2e49bd2..0a4c97b 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -323,7 +323,7 @@ static __init int setup_hugepagesz(char *opt) > static __init int add_default_hugepagesz(void) > { > if (size_to_hstate(CONT_PTES * PAGE_SIZE) == NULL) > - hugetlb_add_hstate(CONT_PMD_SHIFT); > + hugetlb_add_hstate(CONT_PTE_SHIFT); > return 0; > } > arch_initcall(add_default_hugepagesz); It looks like I fixed this already when I merged some other hugetlb patches. See commit 6ed0038d5ecb ("arm64: Fix typo in add_default_hugepagesz() for 64K pages"). -- Catalin