From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759229AbdACNyF (ORCPT ); Tue, 3 Jan 2017 08:54:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36450 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759145AbdACNv6 (ORCPT ); Tue, 3 Jan 2017 08:51:58 -0500 Date: Tue, 3 Jan 2017 14:52:20 +0100 From: Greg KH To: Max Bires Cc: arnd@arndb.de, josh@joshtriplett.org, linux-kernel@vger.kernel.org, geert@linux-m68k.org Subject: Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Message-ID: <20170103135219.GA25120@kroah.com> References: <1481675545-84255-1-git-send-email-jbires@google.com> <1483447993-45232-1-git-send-email-jbires@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483447993-45232-1-git-send-email-jbires@google.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 04:53:13AM -0800, Max Bires wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel, attack surface reduction) if it's not being used. Adding > a message here in order to make this user visible. > > Signed-off-by: Max Bires > Acked-by: Arnd Bergmann > --- > drivers/char/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > index 7ad3127..e8fc493 100644 > --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig > @@ -589,10 +589,13 @@ config TELCLOCK > controlling the behavior of this hardware. > > config DEVPORT > - bool > + bool "/dev/port character device" > depends on !M68K > depends on ISA || PCI > default y > + help > + Say Y here if you want to support the /dev/port device. The > + /dev/port device is similar to /dev/mem, but for I/O ports. > > config DCC_TTY > tristate "DCC tty driver" This does not apply at all to 4.10-rc2, what did you make it against? Please redo it so that I can actually apply it... thanks, greg k-h