From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: David Gstir <david@sigma-star.at>
Cc: linux-geode@lists.infradead.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, teheo@suse.de,
prasannatsmkumar@gmail.com, Richard Weinberger <richard@nod.at>
Subject: Re: Geode LX AES/RNG driver triggers warning
Date: Tue, 3 Jan 2017 14:52:03 +0000 [thread overview]
Message-ID: <20170103145203.780d3c58@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <A0185338-47A4-42BE-B2D4-F1EB082593E3@sigma-star.at>
On Sat, 31 Dec 2016 00:58:54 +0100
David Gstir <david@sigma-star.at> wrote:
> Hi!
>
> I recently tested kernel v4.9 on my AMD Geode platform and noticed that its AES hardware driver triggers this warning on initialization:
...
> I narrowed it down to commit 6e9b5e76882c ("hwrng: geode - Migrate to managed API") which seems to introduce this. It looks to me like some issue between devres, the Geode hwrng and AES drivers which both use the same PCI device.
It does
> I'm no expert here, but I curious if this will cause any issues when using the hardware crypto drivers and also what's the best way to get rid of this?
Probably to create an mfd device that turns the PCI device into two MFD
devices and bind AES and hwrng one to each MFD device. Take a look in
drivers/mfd. That would also fix the uglies in mod_init for the rng
driver.
Alan
next prev parent reply other threads:[~2017-01-03 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 23:58 Geode LX AES/RNG driver triggers warning David Gstir
2017-01-03 14:52 ` One Thousand Gnomes [this message]
2017-01-06 9:40 ` PrasannaKumar Muralidharan
2017-01-06 13:19 ` David Gstir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103145203.780d3c58@lxorguk.ukuu.org.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=david@sigma-star.at \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasannatsmkumar@gmail.com \
--cc=richard@nod.at \
--cc=teheo@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).