From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759166AbdACP1i (ORCPT ); Tue, 3 Jan 2017 10:27:38 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46530 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759035AbdACP0B (ORCPT ); Tue, 3 Jan 2017 10:26:01 -0500 Date: Tue, 3 Jan 2017 16:26:23 +0100 From: Greg KH To: Ozgur Karatas Cc: Scott Matheina , "thomas.petazzoni@free-electrons.com" , "noralf@tronnes.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drivers: staging: fbtft: fix checkpatch error and udelay Message-ID: <20170103152623.GA26457@kroah.com> References: <1482083250-25867-1-git-send-email-scott@matheina.com> <20161219063547.GB5814@kroah.com> <83861482169482@web2o.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83861482169482@web2o.yandex.ru> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2016 at 07:44:42PM +0200, Ozgur Karatas wrote: > 19.12.2016, 08:35, "Greg KH" : > > On Sun, Dec 18, 2016 at 11:47:30AM -0600, Scott Matheina wrote: > >>  These changes where identified by checkpatch.pl as needed changes to > >>  align the code with the linux development coding style. The several > >>  lines of text where aligned with the precending parenthesis. > >> > >>  Signed-off-by: Scott Matheina > >> > >>   Changes to be committed: > >>          modified: drivers/staging/fbtft/fb_agm1264k-fl.c > > > > Why are these lines in the changelog text? > > I checked with checkpatch script to code and give a some errors. > So, the code have to "udelay(20)". > > udelay(20); > > I read to Documentation/timers/timers-howto.txt and > this line incorrect, usleep_range need must be add defined U_DELAY and fixed. > > udelay(U_DELAY, U_DELAY + 10); > > finally: > > $ checkpatch.pl drivers/staging/fbtft/fb_agm1264k-fl.c | grep total > total: 0 errors > > Signed-off-by: Ozgur Karatas > > --- > drivers/staging/fbtft/fb_agm1264k-fl.c | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) You do realize there's nothing I can do with this patch as-is, right? Please fix up the changelog text and resend it properly if you wish to have it included. thanks, greg k-h