From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965942AbdACUr5 (ORCPT ); Tue, 3 Jan 2017 15:47:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:53873 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934875AbdACUrt (ORCPT ); Tue, 3 Jan 2017 15:47:49 -0500 Date: Tue, 3 Jan 2017 21:47:45 +0100 From: Michal Hocko To: Vlastimil Babka Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Johannes Weiner , Rik van Riel , LKML Subject: Re: [PATCH 4/7] mm, vmscan: show LRU name in mm_vmscan_lru_isolate tracepoint Message-ID: <20170103204745.GC13873@dhcp22.suse.cz> References: <20161228153032.10821-1-mhocko@kernel.org> <20161228153032.10821-5-mhocko@kernel.org> <19b44b6e-037f-45fd-a13a-be5d87259e75@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b44b6e-037f-45fd-a13a-be5d87259e75@suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 03-01-17 18:08:58, Vlastimil Babka wrote: > On 12/28/2016 04:30 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > mm_vmscan_lru_isolate currently prints only whether the LRU we isolate > > from is file or anonymous but we do not know which LRU this is. It is > > useful to know whether the list is file or anonymous as well. Change > > the tracepoint to show symbolic names of the lru rather. > > > > Signed-off-by: Michal Hocko > > --- > > include/trace/events/vmscan.h | 20 ++++++++++++++------ > > mm/vmscan.c | 2 +- > > 2 files changed, 15 insertions(+), 7 deletions(-) > > > > diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h > > index 6af4dae46db2..cc0b4c456c78 100644 > > --- a/include/trace/events/vmscan.h > > +++ b/include/trace/events/vmscan.h > > @@ -36,6 +36,14 @@ > > (RECLAIM_WB_ASYNC) \ > > ) > > > > +#define show_lru_name(lru) \ > > + __print_symbolic(lru, \ > > + {LRU_INACTIVE_ANON, "LRU_INACTIVE_ANON"}, \ > > + {LRU_ACTIVE_ANON, "LRU_ACTIVE_ANON"}, \ > > + {LRU_INACTIVE_FILE, "LRU_INACTIVE_FILE"}, \ > > + {LRU_ACTIVE_FILE, "LRU_ACTIVE_FILE"}, \ > > + {LRU_UNEVICTABLE, "LRU_UNEVICTABLE"}) > > + > > Does this work with external tools such as trace-cmd, i.e. does it export > the correct format file? How do I find out? > I wouldn't expect it to be that easy to avoid the EM()/EMe() dance :) Well, I will not pretend I understand the EM dances... > Also can we make the symbolic names lower_case and without the LRU_ prefix? > I think it's more consistent with other mm tracepoints, shorter and nicer. OK, will make it lowercase without the LRU_ prefix. -- Michal Hocko SUSE Labs