From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967337AbdADBiX (ORCPT ); Tue, 3 Jan 2017 20:38:23 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34682 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760382AbdADBiN (ORCPT ); Tue, 3 Jan 2017 20:38:13 -0500 From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: torvalds@linux-foundation.org, pebolle@tiscali.nl, ppandit@redhat.com, mmarek@suse.cz, Florian Fainelli , "Francisco Blas Izquierdo Riera (klondike)" , Andrew Morton Subject: [PATCH] initramfs: Fix spurious rebuilds Date: Tue, 3 Jan 2017 17:37:30 -0800 Message-Id: <20170104013732.26401-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 35e669e1a254 ("initramfs: select builtin initram compression algorithm on KConfig instead of Makefile") makes suffix_y be a quote variable, which can be illustrated looking at the build output: GEN usr/initramfs_data.cpio".gz" Make sure that we do strip off double quotes from CONFIG_INITRAMFS_COMPRESSION, since the Makefile tracks targets with unquoted suffixes. Fixes: 35e669e1a254 ("initramfs: select builtin initram compression algorithm on KConfig instead of Makefile") Signed-off-by: Florian Fainelli --- This is against v4.10-rc2, thanks! usr/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr/Makefile b/usr/Makefile index 17a513268325..a9ae8b493e2b 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -5,7 +5,7 @@ klibcdirs:; PHONY += klibcdirs -suffix_y = $(CONFIG_INITRAMFS_COMPRESSION) +suffix_y = $(subst ",,$(CONFIG_INITRAMFS_COMPRESSION)) AFLAGS_initramfs_data.o += -DINITRAMFS_IMAGE="usr/initramfs_data.cpio$(suffix_y)" # Generate builtin.o based on initramfs_data.o -- 2.9.3