From: Daniel Vetter <daniel@ffwll.ch>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
kbuild test robot <fengguang.wu@intel.com>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH] drm: nouveau: fix build when LEDS_CLASS=m
Date: Wed, 4 Jan 2017 09:45:08 +0100 [thread overview]
Message-ID: <20170104084508.m54kwdkl2z6s3ruk@phenom.ffwll.local> (raw)
In-Reply-To: <029a1ec5-48ac-a3ce-3106-430e0f2584bb@infradead.org>
On Sun, Jan 01, 2017 at 04:20:53PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors in nouveau driver when CONFIG_LEDS_CLASS=m and
> CONFIG_DRM_NOUVEAU=y.
> If LEDS_CLASS is enabled, DRM_NOUVEAU is restricted to the same
> kconfig value as LEDS_CLASS.
>
> drivers/built-in.o: In function `nouveau_do_suspend':
> nouveau_drm.c:(.text+0x2030b1): undefined reference to `nouveau_led_suspend'
> drivers/built-in.o: In function `nouveau_do_resume':
> nouveau_drm.c:(.text+0x2034ca): undefined reference to `nouveau_led_resume'
> drivers/built-in.o: In function `nouveau_drm_unload':
> nouveau_drm.c:(.text+0x203a15): undefined reference to `nouveau_led_fini'
> drivers/built-in.o: In function `nouveau_drm_load':
> nouveau_drm.c:(.text+0x204423): undefined reference to `nouveau_led_init'
>
> BTW, this line in Kbuild:
> nouveau-$(CONFIG_LEDS_CLASS) += nouveau_led.o
> does nothing when CONFIG_LEDS_CLASS=m and CONFIG_DRM_NOUVEAU=y.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Martin Peres <martin.peres@free.fr>
> Cc: Ben Skeggs <bskeggs@redhat.com>
Thrown into drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/nouveau/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-410-rc2.orig/drivers/gpu/drm/nouveau/Kconfig
> +++ lnx-410-rc2/drivers/gpu/drm/nouveau/Kconfig
> @@ -1,6 +1,7 @@
> config DRM_NOUVEAU
> tristate "Nouveau (NVIDIA) cards"
> depends on DRM && PCI
> + depends on LEDS_CLASS || LEDS_CLASS=n
> select FW_LOADER
> select DRM_KMS_HELPER
> select DRM_TTM
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-01-04 8:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 0:20 [PATCH] drm: nouveau: fix build when LEDS_CLASS=m Randy Dunlap
2017-01-04 8:45 ` Daniel Vetter [this message]
2017-01-04 14:25 ` Ilia Mirkin
2017-01-05 2:52 ` Randy Dunlap
2017-01-05 3:09 ` Ilia Mirkin
2017-01-05 3:17 ` Randy Dunlap
2017-01-05 3:23 ` Ilia Mirkin
2017-01-04 19:29 ` Jani Nikula
2017-01-04 22:24 ` Randy Dunlap
2017-01-05 8:01 ` Daniel Vetter
2017-01-05 16:08 ` Randy Dunlap
2017-01-09 10:59 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104084508.m54kwdkl2z6s3ruk@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).