From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mfd: axp20x: Add a few missing defines for AXP288 specific registers
Date: Wed, 4 Jan 2017 09:08:10 +0000 [thread overview]
Message-ID: <20170104090810.GO27589@dell> (raw)
In-Reply-To: <20161216200906.10028-1-hdegoede@redhat.com>
On Fri, 16 Dec 2016, Hans de Goede wrote:
> Add defines for the AXP288_POWER_REASON and AXP288_RT_BATT_V_H and
> AXP288_RT_BATT_V_L and AXP288_BC_* registers. While at it also move the
> AXP288_TS_ADC_H-AXP288_GP_ADC_L defines, which for some reason where
> in a different place, together with the rest of the AXP288 specific
> defines.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes v2:
> -New patch in v2 of this set
> Changes v3:
> -Also add defines for the AXP288_BC_* registers
> ---
> include/linux/mfd/axp20x.h | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
Applied, thanks.
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index fe93e00..5edf421 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -229,9 +229,20 @@ enum {
> #define AXP22X_BATLOW_THRES1 0xe6
>
> /* AXP288 specific registers */
> +#define AXP288_POWER_REASON 0x02
> +#define AXP288_BC_GLOBAL 0x2c
> +#define AXP288_BC_VBUS_CNTL 0x2d
> +#define AXP288_BC_USB_STAT 0x2e
> +#define AXP288_BC_DET_STAT 0x2f
> #define AXP288_PMIC_ADC_H 0x56
> #define AXP288_PMIC_ADC_L 0x57
> +#define AXP288_TS_ADC_H 0x58
> +#define AXP288_TS_ADC_L 0x59
> +#define AXP288_GP_ADC_H 0x5a
> +#define AXP288_GP_ADC_L 0x5b
> #define AXP288_ADC_TS_PIN_CTRL 0x84
> +#define AXP288_RT_BATT_V_H 0xa0
> +#define AXP288_RT_BATT_V_L 0xa1
>
> /* Fuel Gauge */
> #define AXP288_FG_RDC1_REG 0xba
> @@ -508,11 +519,6 @@ enum axp809_irqs {
> AXP809_IRQ_GPIO0_INPUT,
> };
>
> -#define AXP288_TS_ADC_H 0x58
> -#define AXP288_TS_ADC_L 0x59
> -#define AXP288_GP_ADC_H 0x5a
> -#define AXP288_GP_ADC_L 0x5b
> -
> struct axp20x_dev {
> struct device *dev;
> int irq;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-04 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 20:09 [PATCH v3 1/2] mfd: axp20x: Add a few missing defines for AXP288 specific registers Hans de Goede
2016-12-16 20:09 ` [PATCH v3 2/2] mfd: axp20x: Fix axp288 volatile ranges Hans de Goede
2016-12-17 15:12 ` Chen-Yu Tsai
2016-12-18 19:18 ` Hans de Goede
2017-01-04 9:08 ` Lee Jones
2016-12-17 15:10 ` [PATCH v3 1/2] mfd: axp20x: Add a few missing defines for AXP288 specific registers Chen-Yu Tsai
2017-01-04 9:08 ` Lee Jones [this message]
2017-01-04 9:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104090810.GO27589@dell \
--to=lee.jones@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).