From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935974AbdADKUY (ORCPT ); Wed, 4 Jan 2017 05:20:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:56585 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759564AbdADKUH (ORCPT ); Wed, 4 Jan 2017 05:20:07 -0500 From: Vlastimil Babka To: Jiri Kosina Cc: linux-kernel@vger.kernel.org, Vlastimil Babka , Matthew Wilcox Subject: [PATCH] floppy: replace wrong kmalloc(GFP_USER) with GFP_KERNEL Date: Wed, 4 Jan 2017 11:19:31 +0100 Message-Id: <20170104101931.10165-1-vbabka@suse.cz> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The raw_cmd_copyin() function does a kmalloc() with GFP_USER, although the allocated structure is obviously not mapped to userspace, just copied from/to. In this case GFP_KERNEL is more appropriate, so let's use it, although in the current implementation this does not manifest as any error. Reported-by: Matthew Wilcox Signed-off-by: Vlastimil Babka --- drivers/block/floppy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index e3d8e4ced4a2..7f3e68acd787 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -3119,7 +3119,7 @@ static int raw_cmd_copyin(int cmd, void __user *param, *rcmd = NULL; loop: - ptr = kmalloc(sizeof(struct floppy_raw_cmd), GFP_USER); + ptr = kmalloc(sizeof(struct floppy_raw_cmd), GFP_KERNEL); if (!ptr) return -ENOMEM; *rcmd = ptr; -- 2.11.0